Skip to content

[ENG-8749] Implement SSO attributes de-duplication for email and names#11274

Merged
cslzchen merged 6 commits into
CenterForOpenScience:masterfrom
cslzchen:hotfix/instn-dedupe-attr
Sep 10, 2025
Merged

[ENG-8749] Implement SSO attributes de-duplication for email and names#11274
cslzchen merged 6 commits into
CenterForOpenScience:masterfrom
cslzchen:hotfix/instn-dedupe-attr

Conversation

@cslzchen

@cslzchen cslzchen commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

Purpose

Implement SSO attributes de-duplication for email and names

Changes

  • Attempt to deduplicate emails and names
    • If successful, log sentry and let API return success to CAS
    • However, if found multiple different emails, raise error and inform CAS

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-8749

Comment thread framework/auth/__init__.py Outdated

@futa-ikeda futa-ikeda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor and optional nits that I had, but looks good to me once your comment is addressed

Comment thread framework/auth/__init__.py Outdated
Comment thread framework/auth/exceptions.py

@futa-ikeda futa-ikeda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@cslzchen
cslzchen force-pushed the hotfix/instn-dedupe-attr branch from e600a75 to 4b8ac5b Compare September 10, 2025 13:57
@cslzchen
cslzchen merged commit 7c0c495 into CenterForOpenScience:master Sep 10, 2025
7 checks passed
@cslzchen
cslzchen deleted the hotfix/instn-dedupe-attr branch May 21, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants