104 raise errors when appropriate in is public method#105
Merged
BMatischen01 merged 8 commits intoSep 3, 2025
Merged
Conversation
prompt_pat will get errors from is_public method.
douglowe
suggested changes
Sep 3, 2025
douglowe
left a comment
douglowe
left a comment
There was a problem hiding this comment.
couple of small changes, otherwise looks reasonable
SJaffa
deleted the
104-raise-errors-when-appropriate-in-is_public-method
branch
September 4, 2025 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104 by adding explicit code checks in
is_publicfor 401 and 403, which are valid codes to indicate a project is not public. Any other codes or expected errors are raised, and regression tests have been added to ensure the errors raised fromis_publicget caught when it's used incli.pyandexporter.py.