[ENG-8489] | enforce MAX_SIZE on .xls rendering just like was on .xlsx …#397
Merged
cslzchen merged 2 commits intoAug 5, 2025
Merged
Conversation
…and display overflow banner if table exceeds MAX_SIZE limit
cslzchen
requested changes
Aug 5, 2025
cslzchen
left a comment
cslzchen
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall with a few questions ⭐
| if getattr(ws, 'max_row', None) is None or getattr(ws, 'max_column', None) is None: | ||
| raise CorruptedError | ||
|
|
||
| ncols = getattr(ws, "max_column", 0) or 0 |
Contributor
There was a problem hiding this comment.
I don't think we need the or 0 part?
…and display overflow banner if table exceeds MAX_SIZE limit
cslzchen
approved these changes
Aug 5, 2025
cslzchen
left a comment
cslzchen
left a comment
Contributor
There was a problem hiding this comment.
Looks good with a non-blocking suggestion :)
cslzchen
merged commit Aug 5, 2025
231f5be
into
CenterForOpenScience:feature/buff-worms
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and display overflow banner if table exceeds MAX_SIZE limit
Ticket
Purpose
Changes
Side effects
QA Notes
Deployment Notes