[ENG-6835] [ENG-8059] [ENG-8289] VRL Project PR - GV#308
Merged
Conversation
Co-authored-by: Yuhuai Liu <yuhuai@cos.io>
[ENG-7568][ENG-7569][ENG-7570][ENG-7571] Added external_service, configured_addon, authorized_account
…-resource-linking
[ENG-7757][ENG-7310] 3.2.3 GV: Enable GV->OSF messaging - (GV part)
brianjgeiger
approved these changes
Jun 27, 2025
… viewsets to remove unused methods
[ENG-8317] For the sake of sanity
[ENG-8317] Fix GV session/cookie issue which breaks Zotero/OAuth1 addons
[ENG-8028][ENG-8189] 4.1.5 GV Doc: GV API Contacts -> Swagger API
cslzchen
commented
Jul 7, 2025
cslzchen
left a comment
cslzchen
left a comment
Collaborator
Author
There was a problem hiding this comment.
First, let's make sure we updated settings for all servers
- Production (during prod release)
- Test (during test server deployment)
- Staging 1 partial update (after PR merge)
- Staging 2 (after PR merge)
- Staging 3 (after PR merge)
- Staging 4 (after PR merge)
- Staging 5 (after PR merge)
Second, we need to manually run DB migrations (prod only)
Third, we need to set-up Dataverse (LINK type) for at least test and prod after respective deployment.
| SESSION_COOKIE_HTTPONLY = env.SESSION_COOKIE_HTTPONLY | ||
| SESSION_COOKIE_SAMESITE = env.SESSION_COOKIE_SAMESITE | ||
| OSF_AUTH_COOKIE_SECRET = env.OSF_AUTH_COOKIE_SECRET | ||
| REDIS_HOST = env.REDIS_HOST |
Collaborator
Author
There was a problem hiding this comment.
GV Deployment notes: REDIS_HOST should be the same as what OSF uses for REDIS_HOST. This maybe different for each server.
Comment on lines
+65
to
+75
| OSF_AUTH_COOKIE_NAME = env.OSF_AUTH_COOKIE_NAME | ||
| OSF_BASE_URL = env.OSF_BASE_URL.rstrip("/") | ||
| OSF_API_BASE_URL = env.OSF_API_BASE_URL.rstrip("/") | ||
| ALLOWED_RESOURCE_URI_PREFIXES = {OSF_BASE_URL} | ||
| SESSION_ENGINE = "django.contrib.sessions.backends.cache" | ||
| SESSION_COOKIE_NAME = env.OSF_AUTH_COOKIE_NAME | ||
| SESSION_COOKIE_DOMAIN = env.SESSION_COOKIE_DOMAIN | ||
| SESSION_COOKIE_SECURE = env.SESSION_COOKIE_SECURE | ||
| SESSION_COOKIE_HTTPONLY = env.SESSION_COOKIE_HTTPONLY | ||
| SESSION_COOKIE_SAMESITE = env.SESSION_COOKIE_SAMESITE | ||
| OSF_AUTH_COOKIE_SECRET = env.OSF_AUTH_COOKIE_SECRET |
Collaborator
Author
There was a problem hiding this comment.
GV Deployment notes: cookie settings should be the same as their OSF settings for each server, which might be different for different servers.
OSF_AUTH_COOKIE_NAME: set toosf.io's value forCOOKIE_NAMESESSION_COOKIE_DOMAIN:set toosf.io's value forOSF_COOKIE_DOMAIN`SESSION_COOKIE_SECURE: set toosf.io's value forSESSION_COOKIE_SECURESESSION_COOKIE_HTTPONLY: set toosf.io's value forSESSION_COOKIE_HTTPONLYSESSION_COOKIE_SAMESITE: set toosf.io's value forSESSION_COOKIE_SAMESITEOSF_AUTH_COOKIE_SECRET: set toosf.io's value forSECRET_KEY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Verified Resource Linking - GV Part
Changes
VRL
LINKLINKadd-on implementation: DataverseBonus
Side Effects
N/A
API Documentation
WIP: Swagger API
QE Notes
See project QA plan and tickets
CE Notes
WIP: Release playbook