Fix print2 pageSize: honour template CSS @page size when no explicit pageSize is passed#90
Draft
Copilot wants to merge 2 commits into
Draft
Fix print2 pageSize: honour template CSS @page size when no explicit pageSize is passed#90Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…e is not explicitly specified Agent-Logs-Url: https://github.com/CcSimple/electron-hiprint/sessions/fd83ea19-6308-42fa-af9d-e7e2ab6c4228 Co-authored-by: Xavier9896 <34981520+Xavier9896@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pageSize parameter issue in print2 functionality
Fix print2 pageSize: honour template CSS @page size when no explicit pageSize is passed
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron's
webContents.print()defaultspreferCSSPageSizetofalse, silently ignoring the@page { size }rule thevue-plugin-hiprinttemplate engine injects into every rendered HTML. This caused the printer to fall back to its hardware default paper regardless of the template's designed paper size.Changes
src/print.js— addedpreferCSSPageSizetoPRINT_WINDOW.webContents.print()(theprint2/"news"path)src/render.js— same fix forRENDER_WINDOW.webContents.print()(render-printpath)README.md— documented the resulting default behaviourBehaviour
preferCSSPageSizeprint2(data, { printer })— nopageSizetrue@page { size }(receipt/label printers now work)print2(data, { printer, pageSize: 'A4' })falseprint2(data, { preferCSSPageSize: true/false, … })