Skip to content

Restore tests + enforce javac-compatible layout#103

Merged
wisnesky merged 3 commits into
CategoricalData:masterfrom
caverac:test/restore-and-relocate
May 9, 2026
Merged

Restore tests + enforce javac-compatible layout#103
wisnesky merged 3 commits into
CategoricalData:masterfrom
caverac:test/restore-and-relocate

Conversation

@caverac
Copy link
Copy Markdown
Contributor

@caverac caverac commented May 8, 2026

Two earlier PRs added unit-test coverage:

All three were merged to master.

What went wrong

The tests broke Eclipse / bare-javac build!!
CQL uses a flat layout where src/ itself is the single source root (sources live at src/catdata/...). The new tests were placed under src/test/... (aiming to reproduce the folder structure of the project):

  • Gradle, configured with two source roots, accepted this
  • Eclipse (single src/ root) and bare javac from the project root flagged it as a path/package mismatch.

Solution

Tests moved next to the code they exercise, distinguished by file-name suffix (*Test.java, *TestHelpers.java) — e.g. src/catdata/cql/fdm/ImportAlgebraTest.java. Package declarations already matched, so no source edits were needed.

This PR also adds a build step to the ci, that way we can catch potential compiling issues before code is merged

@wisnesky wisnesky merged commit 716b4d8 into CategoricalData:master May 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants