Restore tests + enforce javac-compatible layout#103
Merged
wisnesky merged 3 commits intoMay 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two earlier PRs added unit-test coverage:
ci/quality-checks(CI scaffolding: Checkstyle/SpotBugs/Spotless + workflow)test/apg-coverage(catdata/apg/*tests)test/cql-fdm-coverage(catdata/cql/fdm/*tests)All three were merged to
master.What went wrong
The tests broke Eclipse / bare-
javacbuild!!CQL uses a flat layout where
src/itself is the single source root (sources live atsrc/catdata/...). The new tests were placed undersrc/test/...(aiming to reproduce the folder structure of the project):src/root) and barejavacfrom the project root flagged it as a path/package mismatch.Solution
Tests moved next to the code they exercise, distinguished by file-name suffix (
*Test.java,*TestHelpers.java) — e.g.src/catdata/cql/fdm/ImportAlgebraTest.java. Package declarations already matched, so no source edits were needed.This PR also adds a build step to the ci, that way we can catch potential compiling issues before code is merged