Skip to content

Fixed flaky test testDateHandling in TimestampsParquetReaderTest.java with JSONAssert #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CaseyPan wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed flaky test testDateHandling in TimestampsParquetReaderTest.java with JSONAssert #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2eb7b5
fix flaky TimestampsParquetReaderTest with JSONAssert
Sep 27, 2023
e0d0607
Matching java format
Sep 28, 2023
a895ef1
TimestampsParquetReaderTest checkstyle format changed
Oct 27, 2023
00a3747
change fix with ObjectMapper instead of JSONAssert
Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...nsions/src/test/java/org/apache/druid/data/input/parquet/TimestampsParquetReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.druid.data.input.parquet;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableList;
import org.apache.druid.data.input.ColumnsFilter;
import org.apache.druid.data.input.InputEntityReader;
Expand Down Expand Up @@ -82,6 +83,8 @@ public void testDateHandling() throws IOException
schemaAsDate,
JSONPathSpec.DEFAULT
);
ObjectMapper objectMapperString = new ObjectMapper();
ObjectMapper objectMapperDate = new ObjectMapper();
List<InputRowListPlusRawValues> sampledAsString = sampleAllRows(readerAsString);
List<InputRowListPlusRawValues> sampledAsDate = sampleAllRows(readerAsDate);
final String expectedJson = "{\n"
Expand All @@ -91,8 +94,8 @@ public void testDateHandling() throws IOException
+ " \"idx\" : 1,\n"
+ " \"date_as_date\" : 1497744000000\n"
+ "}";
Assert.assertEquals(expectedJson, DEFAULT_JSON_WRITER.writeValueAsString(sampledAsString.get(0).getRawValues()));
Assert.assertEquals(expectedJson, DEFAULT_JSON_WRITER.writeValueAsString(sampledAsDate.get(0).getRawValues()));
Assert.assertEquals(objectMapperString.readTree(expectedJson), objectMapperString.readTree(DEFAULT_JSON_WRITER.writeValueAsString(sampledAsString.get(0).getRawValues())));
Assert.assertEquals(objectMapperDate.readTree(expectedJson), objectMapperDate.readTree(DEFAULT_JSON_WRITER.writeValueAsString(sampledAsDate.get(0).getRawValues())));
}

@Test
Expand Down