Fix silent stream stalls and permanent data loss#3
Open
RestartFU wants to merge 0 commit into
Open
Conversation
- stream.go: flush parked reorder-queue frames after Read drains the buffer - connection.go/receive_queue.go: stop acknowledging packets that are then dropped by the receive window (ack-then-drop lost data permanently) - retransmission_queue.go/connection.go: close the connection when a reliable packet exhausts retransmission attempts instead of silently dropping it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three receive/retransmit fixes: flush parked frames after
Readdrains the buffer (streams stalled forever with an idle sender), stop acking packets the receive window then drops (permanent data loss), and close the connection when retransmission attempts are exhausted instead of silently dropping a reliable packet. Tests pass.