Feature: Support all transport_opts in connect_options for WebSocket connections#20
Merged
mcrumm merged 2 commits intoMar 10, 2026
Conversation
- Extract full transport_opts keyword list from connect_options - Pass all transport options to Slipstream configuration - Maintain default 30,000ms timeout for backwards compatibility - Enables SSL configuration, mTLS, and other transport-level options
…date Documentation
mcrumm
reviewed
Mar 10, 2026
Comment on lines
+135
to
+146
| iex> req = Req.new(base_url: "https://secure-api.example.com") |> AbsintheClient.attach() | ||
| iex> {:ok, ws} = req |> AbsintheClient.WebSocket.connect( | ||
| ...> connect_options: [ | ||
| ...> transport_opts: [ | ||
| ...> verify: :verify_peer, | ||
| ...> cacertfile: "/path/to/ca.pem", | ||
| ...> certfile: "/path/to/client-cert.pem", | ||
| ...> keyfile: "/path/to/client-key.pem" | ||
| ...> ] | ||
| ...> ] | ||
| ...> ) | ||
| iex> ws |> GenServer.whereis() |> Process.alive?() |
Member
There was a problem hiding this comment.
This module runs doctests so we need to change the syntax here so that this block is not treated as a test.
Suggested change
| iex> req = Req.new(base_url: "https://secure-api.example.com") |> AbsintheClient.attach() | |
| iex> {:ok, ws} = req |> AbsintheClient.WebSocket.connect( | |
| ...> connect_options: [ | |
| ...> transport_opts: [ | |
| ...> verify: :verify_peer, | |
| ...> cacertfile: "/path/to/ca.pem", | |
| ...> certfile: "/path/to/client-cert.pem", | |
| ...> keyfile: "/path/to/client-key.pem" | |
| ...> ] | |
| ...> ] | |
| ...> ) | |
| iex> ws |> GenServer.whereis() |> Process.alive?() | |
| > req = Req.new(base_url: "https://secure-api.example.com") |> AbsintheClient.attach() | |
| > {:ok, ws} = req |> AbsintheClient.WebSocket.connect( | |
| > connect_options: [ | |
| > transport_opts: [ | |
| > verify: :verify_peer, | |
| > cacertfile: "/path/to/ca.pem", | |
| > certfile: "/path/to/client-cert.pem", | |
| > keyfile: "/path/to/client-key.pem" | |
| > ] | |
| > ] | |
| > ) | |
| > ws |> GenServer.whereis() |> Process.alive?() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
AbsintheClient.WebSocketonly passes the:timeoutoption from:connect_optionsto the underlying Mint WebSocket connection. This limits users who need to configure other transport-level options, such as SSL verification settings.Solution
Modified
run_ws_options/1to extract and pass through alltransport_optsfrom:connect_optionsto Slipstream'smint_opts, while maintaining the default 30,000ms timeout for backwards compatibility.Use Cases
This change enables several important scenarios:
Changes
transport_optskeyword list from:connect_optionsTesting
Backwards Compatibility
✅ Fully backwards compatible - existing code continues to work unchanged