Skip to content

ui_app_setup: drop HAL_PLATFORM_SDL guard so emulator builds #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eggfly merged 4 commits into from
Jun 2, 2026
Merged

ui_app_setup: drop HAL_PLATFORM_SDL guard so emulator builds #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
769d34d
ui_app_setup: drop HAL_PLATFORM_SDL guard so emulator can open SETTING
eggfly Jun 2, 2026
d5bb08b
hal_filesystem_sdl: add missing #include <stdio.h> for snprintf
eggfly Jun 2, 2026
14f04fa
ui_app_setup: also remove the SDL stub class block
eggfly Jun 2, 2026
d3fa7da
hal_settings_sdl: stub hal_wifi_disconnect
eggfly Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/APPLaunch/main/hal/sdl/hal_filesystem_sdl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "../hal_filesystem.h"
#include <stdio.h> // snprintf
#include <string.h>
#include <stdlib.h>

Expand Down
2 changes: 2 additions & 0 deletions projects/APPLaunch/main/hal/sdl/hal_settings_sdl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ int hal_wifi_connect(const char *ssid, const char *password)
(void)ssid; (void)password; return 0;
}

int hal_wifi_disconnect(void) { return 0; }

hal_bt_status_t hal_bt_get_status(void)
{
hal_bt_status_t st;
Expand Down
20 changes: 7 additions & 13 deletions projects/APPLaunch/main/ui/components/page_app/ui_app_setup.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#pragma once
#if !defined(HAL_PLATFORM_SDL)
// Note: this file used to be wrapped in `#if !defined(HAL_PLATFORM_SDL)` to
// exclude it from the emulator build, but ui_app_launch.cpp references
// UISetupPage unconditionally. The class body is HAL-clean (uses hal_wifi_*,
// hal_battery_*, hal_volume_*); residual raw syscalls (i2c ioctl, popen for
// IP/whoami, sudo date) are either already inside #ifdef __linux__ or only
// triggered by user actions that the emulator never performs. Keeping the
// class compiled on every platform lets the emulator open the SETTING page.
#define _STRINGIFY(x) #x
#define STRINGIFY(x) _STRINGIFY(x)
#ifndef LAUNCHER_GIT_COMMIT_RAW
Expand Down Expand Up @@ -1728,15 +1734,3 @@ class UISetupPage : public app_base
}
}
};

#else // HAL_PLATFORM_SDL — stub for emulator builds
#include "../ui_app_page.hpp"

class UISetupPage : public app_base
{
public:
UISetupPage() : app_base() { set_page_title("SETTING"); }
~UISetupPage() {}
};

#endif // !HAL_PLATFORM_SDL
Loading