Yield Rework V2 minor follow-up fixes and reveal-suppress pref

[autumnmyst]

• Auto-pass-no-actions with "respects interrupts" now properly breaks on opponent casts and attacker declarations. The event handler gated on isYieldActive() (explicit EOT/stack/marker yields only), so APINA was never told about these events and kept passing; gate on the broader shouldEvaluateInterrupts() instead.
• NPE guards: null phaseOwner/phase in setMarker (treated as a clear), null activator in onSpellAbilityCast, and null si()/negative targetId seen on reconnect-time event replays.
• resetForNewGame() clears per-tick yield flags between games of a match so game 2 doesn't inherit game 1's auto-pass / suggestion state.
• "Suppress reveals while yielding" skips the reveal()/notifyOfValue() modal when set, interrupt-on-reveal is off, and auto-pass is active.

[autumnmyst]

I considered logging the reveals when suppressed, but that seemed like a gameplay change, as normally reveals are not logged. So I concluded no reveals should be logged, suppressed or otherwise. It's explicitly for speed, sacrificing that info.

[Jetz72]

I considered logging the reveals when suppressed, but that seemed like a gameplay change, as normally reveals are not logged. So I concluded no reveals should be logged, suppressed or otherwise.

Is there a standing reason we wouldn't want them in the game log? Or is it just not included because nobody's bothered to include it thus far? My initial impression is that reveals would be a pretty sensible addition to the game log, whether or not the modal is skipped.

[autumnmyst]

I considered logging the reveals when suppressed, but that seemed like a gameplay change, as normally reveals are not logged. So I concluded no reveals should be logged, suppressed or otherwise.

Is there a standing reason we wouldn't want them in the game log? Or is it just not included because nobody's bothered to include it thus far? My initial impression is that reveals would be a pretty sensible addition to the game log, whether or not the modal is skipped.

I agree with that. If that's a feature we're looking for it's a simple addition. I wasn't sure if remembering what was revealed manually was an important piece of gameplay, though personally I would rather log it.

[MostCromulent]

Is there a standing reason we wouldn't want them in the game log? Or is it just not included because nobody's bothered to include it thus far? My initial impression is that reveals would be a pretty sensible addition to the game log, whether or not the modal is skipped.

I suspect its just nobody has bothered to add it, and agree it would be good QoL inclusion. Only question is whether it creates any rules issue since in paper cards are just revealed temporarily but log appears as permanent record / you lose the gameplay challenge of having to remember revealed cards?

Edit: apparently MTGO displays revealed cards in some sort of log, and Arena keeps revealed cards visible until hand state changes. So adding to the log should be safe.

If that's a feature we're looking for it's a simple addition.

If consensus is to add reveal logging then imo:

1. It should produce a single log line with all of the cards + the zone they were revealed from, rather than flooding the log with 7 separate entries when a player's hand is revealed.
2. Should be wired up to the "Medium" log verbosity preset and added as a new checkbox to the custom log verbosity dialog; see here for precedent Better game log UI: inline card images, improved verbosity presets #9889