fix(accessibility): improve modal WAI-ARIA compliance and keyboard focus management#469
Open
KrutagyaKaneria wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
This PR improves the accessibility of the shared
Modalcomponent by implementing the WAI-ARIA Dialog Pattern and proper keyboard focus management.✨ Changes Made
role="dialog"to the modal container.aria-modal="true"for assistive technologies.aria-labelledbyusing a stable ID generated withuseId().🎯 Benefits
🧪 Testing
role="dialog"andaria-modalare applied.aria-labelledbycorrectly references the modal title.#GSSoC
#ECSoC26
This PR is submitted as part of GirlScript Summer of Code (GSSoC) 2026.
This refactor improves code reuse and maintainability by centralizing geocoding logic within the existing GeocodeService while preserving all existing functionality. Kindly review and consider approving it if it aligns with the project's Flutter architecture and code quality goals. Thank you for your valuable feedback!
Closes #465