fix: correct remember me token persistence#451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
Remember Melogin bug by ensuring token persistence is controlled in one place only. The login flow now stores the token in eitherlocalStorageorsessionStoragebased on the checkbox state, instead of havingupdateUser()overwrite it afterward.What Changed
updateUser()in the user context.Remember Me.Files Updated
frontend/src/pages/Auth/Login.jsxfrontend/src/context/userContext.jsxBug Fixed #444
Before this change:
Remember Meunchecked still resulted in the token being saved tolocalStorage.After this change:
Remember Mechecked -> token stays inlocalStorageRemember Meunchecked -> token stays insessionStorageTesting Notes
Remember Meunchecked and confirm the token only exists insessionStorage.Remember Mechecked and confirm the token only exists inlocalStorage.Impact
This restores expected authentication behavior and makes session persistence consistent for users.