Skip to content

fix: add validation for session questions and normalize user ID access across controllers#426

Merged
KaranUnique merged 2 commits into
Canopus-Labs:mainfrom
rajdhakad9826:fix/question-controller-validation
Jul 13, 2026
Merged

fix: add validation for session questions and normalize user ID access across controllers#426
KaranUnique merged 2 commits into
Canopus-Labs:mainfrom
rajdhakad9826:fix/question-controller-validation

Conversation

@rajdhakad9826

Copy link
Copy Markdown
Contributor

📝 Pull Request Description

Related Issue

Closes #425

Summary

  • Added request validation in addQuestionToSession to ensure a valid sessionId and a non-empty questions array are provided before processing the request.
  • Added a null check in togglePinQuestion to return 404 Not Found when the requested question does not exist instead of triggering an internal server error.
  • Standardized authenticated user ID access by replacing req.user.id and req.user._id || req.user.id with req.user._id in the affected controllers.

Type of Change

🐛 Bug fix (non-breaking change which fixes an issue)

@KaranUnique

Copy link
Copy Markdown
Contributor

@rajdhakad9826 cloud you please resolve the conflicts

@rajdhakad9826

Copy link
Copy Markdown
Contributor Author

@KaranUnique resolved

@KaranUnique KaranUnique merged commit 2e0d51d into Canopus-Labs:main Jul 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix]: Improve validation and error handling in questionController

2 participants