perf: clone only args in executeOperation, not the whole params#5
Open
Loskir wants to merge 1 commit into
Open
perf: clone only args in executeOperation, not the whole params#5Loskir wants to merge 1 commit into
Loskir wants to merge 1 commit into
Conversation
executeOperation deep-cloned the entire params for every nested operation. Since params carries scope.parentParams (the ancestor chain up to the root query), that redundantly re-cloned every ancestor's args on every nested op — work that grows sharply with nesting depth. Only args is mutated downstream; scope/model/operation are read-only, so cloning just args keeps the no-mutation guarantee and drops the redundant copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executeOperationdeep-clones the entireparamsfor every nested operation. The library never mutatesscope/model/operation— onlyargsis rewritten as operations are transformed — so sharing them by reference should preserve the existing isolation guarantee.Benchmark
I ran
withNestedOperationson a nested query before and after the patch, here is the resultparams)argsonly)This change cuts pre-processing time by ~75-85% depending on nesting. Overall complexity is still worse than O(n) but most of the redundant work is removed.
Here are some flamegraphs (depth 24):
Before (11ms):
After (1.17ms):