Skip to content

Expose play-by-play position fields#250

Merged
CalebRose merged 1 commit into
CalebRose:mainfrom
tpitzel:agent/upstream-expose-pbp-position-fields
Jul 23, 2026
Merged

Expose play-by-play position fields#250
CalebRose merged 1 commit into
CalebRose:mainfrom
tpitzel:agent/upstream-expose-pbp-position-fields

Conversation

@tpitzel

@tpitzel tpitzel commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Add all play-by-play participant-position ID fields to PlayByPlayResponse.
  • Map those fields from the API response in the model constructor.
  • Map Lcb with a fallback to the legacy Fcb response field.

Why

The API play-by-play payload exposes the player IDs assigned to formation positions, but the Interface response model omitted them. That prevented typed Interface code from reliably consuming those values and left the LCB field-name migration unrepresented.

Impact

Interface code can consume the play-by-play participant IDs through the typed model, including both current Lcb and legacy Fcb payloads. This model-only change does not alter the visible Interface by itself.

Checks

  • git diff --check upstream/main...HEAD
  • Direct TypeScript syntax parse of src/models/footballModels.ts
  • The repository-wide tsc --noEmit check was also run; it currently reports existing errors in unrelated files, with no error in the changed model file.

@CalebRose
CalebRose marked this pull request as ready for review July 23, 2026 14:48
@CalebRose
CalebRose merged commit 892bc35 into CalebRose:main Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants