Expose play-by-play position fields#250
Merged
CalebRose merged 1 commit intoJul 23, 2026
Merged
Conversation
CalebRose
approved these changes
Jul 23, 2026
CalebRose
marked this pull request as ready for review
July 23, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PlayByPlayResponse.Lcbwith a fallback to the legacyFcbresponse field.Why
The API play-by-play payload exposes the player IDs assigned to formation positions, but the Interface response model omitted them. That prevented typed Interface code from reliably consuming those values and left the LCB field-name migration unrepresented.
Impact
Interface code can consume the play-by-play participant IDs through the typed model, including both current
Lcband legacyFcbpayloads. This model-only change does not alter the visible Interface by itself.Checks
git diff --check upstream/main...HEADsrc/models/footballModels.tstsc --noEmitcheck was also run; it currently reports existing errors in unrelated files, with no error in the changed model file.