Toolchain update and misc improvements#72
Merged
Conversation
…values Other changes: - Fix a bug in type validation causing all types to be skipped since the default object_trait_dependency is the any trait which is not explicitly listed in the traits list for each type. - Fix a bug where transparent types could have an infinite loop in `instantiate` if they are wrapping a trait type and implement the trait themselves. - Fix a bug in the logic that determines whether an explicit type needs to be written out for a binding. This was skipping the explicit type for `Option`, but there are cases where the value does not hint at the type (i.e. `Option::None` contains no indication of what the generic type parameter should be). - Document that `instantiate` will always produce a value with a type ID that is for a `TypeKind::instanciable` type.
…iation involving traits
…ses for path errors
MavethGH
reviewed
Jun 12, 2026
MavethGH
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the nightly version to keep it in sync with the dreamthorn repo and resolves new lints. This also contains additional improvements that I have added while working on things:
DefaultMakerto enforce type ID assignment to instantiated default valuesOptionby writing out explicit types for generic enums