Move Candle specific files to a new subdirectory#9
Merged
Conversation
As explained in a comment in build-instructions.sh, this leads to a bit of changing directories at the beginning. The following mental model may be useful: all (relative) paths should be relative to the project root. The main wrinkle here is that the cake binary currently expects some files at hardcoded locations - so if we don't want those files to be at the top-level directory, we need to start Candle in a different location, and change directory right after booting. To enable this, we also make use of the new "custom" FFI port - this will become handy in the future for getting the time and calling external binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in a comment in build-instructions.sh, this leads to a bit of changing directories at the beginning.
The following mental model may be useful: all (relative) paths should be relative to the project root. The main wrinkle here is that the cake binary currently expects some files at hardcoded locations - so if we don't want those files to be at the top-level directory, we need to start Candle in a different location, and change directory right after booting.
To enable this, we also make use of the new "custom" FFI port - this will become handy in the future for getting the time and calling external binaries.