Profile changes by tescher · Pull Request #108 · CV19Assist/app

tescher · 2020-05-14T02:50:01Z

I got most of the user profile fka account setup working if either of you can look at it. It's in tescher/app.git in branch profile-changes I'm new to React so there may be things I'm doing completely wrong. I also have a bunch of clean-up to do, but it would be good if you could make a quick pass.

Basic functionality is this:

From the Login screen, you can press the "I'm new here" link and it will take you through a new user sign-up.
Also from Login screen you can press the Google button, and it will do the same, except skip the email/password part.
From NavBar/User/Profile menu, you'll be taken to the same flow, except with a different header (My Profile instead of I Want To Help)
If you log in (with either email/pw or Google) and you're missing required profile data, it will tell you and take you through the profile flow.

When you get through the profile flow, it will attempt to create an account/profile for you. If the email already exists and you didn't use Google, it will tell you and take you back to the beginning.

Things I still need to figure out:

The NavBar issue where you're shown as logged in before you get through the new user flow and you started with Google. I tried storing something in users-public so I could look at it without being logged in, but I don't think that's optimal. Need something else. A custom Firebase user property maybe?
Alignment of the Google button.
Am I saving all the needed data in the right places? Seems like location isn't completely there because the Search keeps using the default location even if I choose a location in my profile.
Tests
We still need a "Forgot Password" flow. Was this already started previously?

* fix(SearchPage): fix the responsive styling of the results * fix(ClickableMap): switch to calling Google Maps API directly Previously, we were using the react-geocode library which was a server side library and did not support domain-based key restrictions. Now using the API directly because it's simple enough and will allow us to support key restrictions. Closes CV19Assist#94 * chore(*): upgrade a few of the older packages. * refactor(AccountMenu): switch to Link component to allow opening in new window * feat(ClickableMap): allow user to enter address We now allow users to enter address on the new request and volunteer sign up pages. On the volunteer sign up page, the address also populates the separate address fields for the volunteer. Closes CV19Assist#29 * fix(NewRequestPage): fix the .length error and styling Fix an error when the user doesn't have the diplayName filled out. Also default displayName to `firstName lastName` when it's not set. Lastly, fix the styling on small screens. Closes CV19Assist#85 * feat(RequestSuccessfulPage): add link to the newly created request * feat(*): hook up sentry.io. (CV19Assist#95) * fix(Discussion): remove the incorrect limit(1) from private comments. * chore(*): update version * Check version before creating new release (CV19Assist#100) * Only run release logic for production branch * refactor(ClickableMap): switch to async/await as suggested * refactor(useNewRequest): copy the requestLocation object before deleting the unneeded property * refactor(utils/geo): log to Sentry when API is not found Co-authored-by: Scott Prue <prescottprue@users.noreply.github.com>

…pp into default-contact-info Pulling in milestone-5 changes

thebitguru

A few issues.

I am getting a permission error when creating a new user.
Pressing enter on a field (e.g., email) shows the "Please fix the errors above" message, but the errors on subsequent steps so the actual error is not visible.
I agree that we need to work on the styling.
How can we merge this with the AccountEditor which will soon display the notification preferences?

thebitguru · 2020-05-14T07:32:47Z

                      "type": "string",
                      "description": "A name for the location, generally 'City, State'."
+                    },
+                    "hasAccount": {


Can we change this to something like profileFilledOut?

thebitguru · 2020-05-14T07:35:12Z

@@ -0,0 +1,51 @@
+import React from 'react';


Should the GoogleSignIn component be inside the Login component since that's the only place it will be needed?

It will be in both the login and new user forms. I just haven't refactored the login form for it yet.

Better idea - I'm going to remove it altogether from the profile flow. It will only live on the login page, and if they press it and don't have a profile, they will be redirected to the profile flow to fill out what's needed. We don't need two buttons.

tescher · 2020-05-14T15:17:01Z

on the permission error, was that an email/pw user or Google user?
it's on my list to figure out how to show the right page based on the error
What will be in the Account page? Maybe the stepper only makes sense for a new user?

tescher · 2020-05-15T00:20:20Z

Done:

Put in code to take user back to the step with validation errors
Removed the Google button from the flow, left it in the Login page
Handle email and password changes (it might require a re-login if the user hasn't logged in recently. May want to handle this somehow. We just show the error currently)

ToDo:

Handle location changes. Will try to geocode the address fields (which are fed by the map, but can be edited) and load the precise location into the user's profile. If the geocode fails, send them back to the map to try again.
Still issue with the NavBar prematurely showing logged in
Create a "Forgot Password" flow
Tests

thebitguru · 2020-05-16T07:37:45Z

on the permission error, was that an email/pw user or Google user?

Google user.

it's on my list to figure out how to show the right page based on the error

What will be in the Account page? Maybe the stepper only makes sense for a new user?

Right. The stepper only seems to be appropriate for new users.

tescher · 2020-05-16T21:43:37Z

Added:

Forgot password (only uses the Firebase default reset page for now)
Save precise location based on address

thebitguru and others added 14 commits May 5, 2020 00:11

Merge branch 'default-contact-info' of git+ssh://github.com/tescher/a…

380c784

…pp into default-contact-info Pulling in milestone-5 changes

Start of user profile

8bea3bd

Current state of profile stepper testing

4737781

More profile loading

2d0d478

Attempting merge

fb2659a

Attempting merge

b4df14b

Intermediate save

e94caec

Finished email/pw new user

2af2a7a

Add Google login

e3cfc36

Add spinner on loading

2b2b174

Added map back in

d2ca623

Hook up login screen

a6af1c7

Fix lints

fedc0ac

thebitguru changed the base branch from master to next May 14, 2020 07:45

thebitguru suggested changes May 14, 2020

View reviewed changes

Validation errors to correct form, and handle change email/pw

aa54329

Password Reset

cb187f9

tescher marked this pull request as ready for review May 15, 2020 20:02

Add in location lookup and save based on address

763e446

lint fixes

bb18b13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Profile changes#108

Profile changes#108
tescher wants to merge 18 commits into
CV19Assist:nextfrom
tescher:profile-changes

tescher commented May 14, 2020

Uh oh!

thebitguru left a comment

Uh oh!

thebitguru May 14, 2020

Uh oh!

tescher May 14, 2020

Uh oh!

thebitguru May 14, 2020

Uh oh!

tescher May 14, 2020

Uh oh!

tescher May 14, 2020

Uh oh!

tescher commented May 14, 2020

Uh oh!

tescher commented May 15, 2020 •

edited

Loading

Uh oh!

thebitguru commented May 16, 2020

Uh oh!

tescher commented May 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tescher commented May 14, 2020

Uh oh!

thebitguru left a comment

Choose a reason for hiding this comment

Uh oh!

thebitguru May 14, 2020

Choose a reason for hiding this comment

Uh oh!

tescher May 14, 2020

Choose a reason for hiding this comment

Uh oh!

thebitguru May 14, 2020

Choose a reason for hiding this comment

Uh oh!

tescher May 14, 2020

Choose a reason for hiding this comment

Uh oh!

tescher May 14, 2020

Choose a reason for hiding this comment

Uh oh!

tescher commented May 14, 2020

Uh oh!

tescher commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thebitguru commented May 16, 2020

Uh oh!

tescher commented May 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tescher commented May 15, 2020 •

edited

Loading