Fix ProposalBasedSampler for JointDistribution - #665
Open
jeverink wants to merge 3 commits into
Open
Conversation
jeverink
changed the title
jeverink
marked this pull request as ready for review
June 25, 2025 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both MH and CWMH samplers could not be used with JointDistribution due to an incorrect initial point.
Closes #658
Closes #659
The current solution is that any
ProposalBasedSamplerautomatically changes theJointDistributiontarget to aStackedJointDistribution, and whenget_samples()gets called, the samples get unstacked to the original geometries.Feel free to suggest any useful tests.