Skip to content

docs: regenerate README demo assets with the 2.0.0 tool + fix broken links#12

Merged
GiuseppeIuculano merged 1 commit into
mainfrom
chore/regenerate-demo-assets
Jun 18, 2026
Merged

docs: regenerate README demo assets with the 2.0.0 tool + fix broken links#12
GiuseppeIuculano merged 1 commit into
mainfrom
chore/regenerate-demo-assets

Conversation

@GiuseppeIuculano

Copy link
Copy Markdown
Member

Problem

The README Example Output click-through links pointed at CTMobi/veo-tools/releases/latest/download/*.mp4, but our v2.0.0 release had no assets — PR #8's "CTMobi everywhere" change repointed them from upstream's kdowswell release (which hosts the MP4s) to ours, without re-hosting the videos. All 6 download links 404'd. (The thumbnails themselves were fine — they're committed.)

Fix — regenerated the demos with the 2.0.0 tool itself

  • Hero loop: /veo single-shot, hero-background use case → 720p/4s, audio off (the context-aware default for hero), then seamless loop via the video-loop skill.
  • 4-shot "Dataflow launch": /veo-multi-shot, marketing use case → fast 1080p/8s, audio on (showcases the new 2.0.0 context-aware audio default), assembled with ffmpeg (32s).
  • Fresh thumbnails (1280px) extracted from the new clips, replacing upstream's.

Uploaded the 6 MP4s as assets to the v2.0.0 release and pinned the README links to the immutable tag (/releases/download/v2.0.0/) instead of /latest/, so they won't drift.

Verification

  • All 6 …/releases/download/v2.0.0/*.mp4 URLs return 200.
  • All 6 referenced thumbnails exist in docs/thumbnails/.
  • npx tsc --noEmit clean · npx vitest run 219/219 (no code touched).
  • Generated live on Vertex AI (project claude-ve); total ~$21.20 as approved.

Note: the fast endpoint was intermittently overloaded during generation; an auto-retry-with-backoff loop caught the recovery windows. No charge for failed attempts.

🤖 Generated with Claude Code

…links

The README 'Example Output' click-through links pointed at
CTMobi/.../releases/latest/download/*.mp4, but our v2.0.0 release had no
assets (PR #8 repointed them from upstream's kdowswell release to ours without
re-hosting the videos), so all 6 download links 404'd.

Regenerated the demo media with the 2.0.0 tool itself:
- Hero loop: /veo single-shot (720p/4s, audio off — hero-background default)
  + seamless loop via the video-loop skill.
- 4-shot 'Dataflow launch': /veo-multi-shot (fast 1080p/8s, audio on — the new
  context-aware audio default for the marketing use case), assembled with ffmpeg.
- Fresh thumbnails (1280px) extracted from the new clips.

Uploaded the 6 MP4s as assets to the v2.0.0 release and pinned the README links
to the immutable tag (/releases/download/v2.0.0/) instead of /latest/. All 6
download URLs verified 200. Generated live on Vertex AI (project claude-ve).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 18, 2026 14:45
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0b625f71-8404-45fb-9ad7-d0426e905722

📥 Commits

Reviewing files that changed from the base of the PR and between d172231 and 92559b6.

⛔ Files ignored due to path filters (6)
  • docs/thumbnails/hero-loop.jpg is excluded by !**/*.jpg
  • docs/thumbnails/multi-shot-assembled.jpg is excluded by !**/*.jpg
  • docs/thumbnails/shot-01-teaser.jpg is excluded by !**/*.jpg
  • docs/thumbnails/shot-02-reveal.jpg is excluded by !**/*.jpg
  • docs/thumbnails/shot-03-detail.jpg is excluded by !**/*.jpg
  • docs/thumbnails/shot-04-context.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Summary by CodeRabbit

Note di rilascio

  • Documentazione
    • Aggiornati i link di esempio nel README per i download video, ora con URL con versione fissa (v2.0.0) anziché link "latest" dinamici.

Walkthrough

In README.md, i link di download degli asset video di esempio vengono aggiornati da URL rolling (releases/latest/download/...) a URL con versione fissa (releases/download/v2.0.0/...), sia per i video principali che per le voci della tabella dei singoli shot.

Changes

Aggiornamento URL video nel README

Layer / File(s) Summary
Pin URL video agli esempi v2.0.0
README.md
I link MP4 nella sezione "Multi-Shot: Marketing Launch Video" (hero-loop e video assemblato) e nelle righe shot 3/4 della tabella "View individual shots" passano dall'URL rolling latest all'URL fisso releases/download/v2.0.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Un coniglio salta nel prato del codice,
le URL ora puntano a v2.0.0 fisse,
niente più "latest" che cambia di nascosto,
ogni video è ancorato al suo posto giusto!
Hop hop, la versione è scritta nel link! 🎬

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: regenerating README demo assets with the 2.0.0 tool and fixing broken links, which matches the primary focus of the changeset.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the problem (broken 404 links), the solution (regenerating demos and updating links), and verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/regenerate-demo-assets
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/regenerate-demo-assets

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Claude finished @GiuseppeIuculano's task in 1m 25s —— View job


Review — PR #12 · Rigenerazione asset demo README

  • Analisi del diff (README.md + 6 thumbnail)
  • Verifica esistenza thumbnail referenziate
  • Controllo coerenza link e documentazione
  • Pubblicazione review

Approvo nel merito. È una PR di sola documentazione, minimale (4 righe modificate in README.md + 6 JPG rigenerate) e fa esattamente quello che dichiara. La sostanza è corretta e il fix è quello giusto.

Cosa ho verificato

  • Coerenza link: tutti e 6 i link puntano ora a …/releases/download/v2.0.0/*.mp4. Non resta nessun riferimento residuo a /releases/latest/ nel repo (grep su releases/(latest|download) → solo le 6 righe nuove). ✔️
  • Thumbnail: tutte le 6 immagini referenziate esistono in docs/thumbnails/ (hero-loop, multi-shot-assembled, shot-01-teaser, shot-02-reveal, shot-03-detail, shot-04-context). ✔️
  • Nessun codice toccato → nessun impatto su test/sicurezza/performance. Il claim "219/219 · tsc clean" è coerente con un diff di sola documentazione.

Osservazioni (nessun blocco)

  1. Pinning al tag immutabile = scelta corretta, con un trade-off da ricordare. Ancorare a /v2.0.0/ invece di /latest/ risolve il problema del 404 ed evita il drift dei link — ottimo. Il rovescio della medaglia: a ogni release futura questi link non si aggiorneranno da soli. Vale la pena aggiungere un promemoria nella checklist di rilascio (sezione "Release documentation" del CONTRIBUTING.md) del tipo: "ricaricare i 6 MP4 demo come asset della nuova release e ribumpare i link nel README", così non si ripresenta il problema di PR docs: update README for Foundation 2.0.0 + point to CTMobi fork #8.

  2. Verifica live degli HTTP 200 non riproducibile da qui. La sandbox CI blocca le chiamate di rete in uscita, quindi non ho potuto ri-confermare in autonomia che i 6 URL restituiscano 200. Mi affido alla verifica documentata nella descrizione della PR. Se volete un controllo automatico permanente, un piccolo job CI che fa curl -sfI sui link del README intercetterebbe regressioni future di questo tipo.

  3. Nit (opzionale): l'alt text Multi-Shot Assembled referenzia il file dataflow-launch-assembled.mp4 — leggera divergenza di naming tra label e asset. Innocua, ma se in futuro toccate quella riga vale la pena allineare i nomi per chiarezza.

Nel complesso: pulito, mirato, mergeabile. 👍
· chore/regenerate-demo-assets

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several asset download links in the README.md file to point to a specific release version (v2.0.0) instead of the generic 'latest' release. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates README demo video links to stop 404s by pointing the “Example Output” thumbnails at the v2.0.0 release assets (immutable tag URL) instead of releases/latest, aligning the documentation with where the MP4s are actually hosted.

Changes:

  • Repointed all README “Example Output” MP4 links from /releases/latest/download/… to /releases/download/v2.0.0/….
  • Kept thumbnail references intact (verified docs/thumbnails/* files exist).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR successfully addresses the issue of broken links by pinning several README assets to the v2.0.0 release tag. Codacy analysis indicates the changes are up to standards with no new quality issues. However, there is an implementation gap regarding the acceptance criteria for thumbnail updates: specifically, 'multi-shot-assembled.jpg' was not modified despite the regeneration of its associated video. Additionally, while the multi-shot video link was pinned to a release asset, other demo links remain pointed at potentially ephemeral external URLs, which may lead to future link rot.

Test suggestions

  • Verify that all video download URLs in the README point to the v2.0.0 release and resolve correctly.
  • Verify that thumbnail image paths referenced in the README correspond to existing files in the 'docs/thumbnails/' directory.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread README.md
A seamless looping abstract background for website hero sections.

[![Hero Loop Example](docs/thumbnails/hero-loop.jpg)](https://github.com/CTMobi/veo-tools/releases/latest/download/hero-loop.mp4)
[![Hero Loop Example](docs/thumbnails/hero-loop.jpg)](https://github.com/CTMobi/veo-tools/releases/download/v2.0.0/hero-loop.mp4)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: The links on lines 13, 30, and 34 use external URLs which may be temporary. To prevent future 'broken links' and ensure the immutability intended by this PR, consider hosting these regenerated assets as attachments in the GitHub Release, following the pattern used for the multi-shot video on line 21.

@GiuseppeIuculano
GiuseppeIuculano merged commit c88ac69 into main Jun 18, 2026
9 checks passed
@GiuseppeIuculano
GiuseppeIuculano deleted the chore/regenerate-demo-assets branch June 18, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants