chore: release-prep fixes for v2.0.0 (audit blockers)#10
Conversation
A release-readiness audit (4 parallel verifiers) found three blockers that would make the v2.0.0 public release inaccurate or broken: - package-lock.json still declared version 1.0.0 (top-level + root package entry); synced to 2.0.0 via 'npm version --no-git-tag-version' (only the two version lines change; dependency tree untouched). - docs/releases/2.0.0.md line-count claims were stale: 'veo-generate.ts 595->46' and 'veo-multi-generate.ts 637->36'. Actual, verified against the v1.0.0 baseline and HEAD: 594->55 and 635->33. - docs/releases/2.0.0.md footer linked CHANGELOG.md and docs/superpowers/ with relative paths (../../, ../) that break when the file is rendered as a GitHub release body. Converted to absolute github.com URLs. Also (nit): CHANGELOG.md CI line said 'npm ci && npm test' but the workflow also runs 'npm run typecheck' — added it for parity with the release notes. npm test 219/219, tsc --noEmit clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughDue file di documentazione vengono aggiornati: ChangesCorrezioni documentazione 2.0.0
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
Claude finished @GiuseppeIuculano's task in 1m 19s —— View job Review PR #10 — release-prep v2.0.0
✅ Esito: approvabilePR di sola documentazione/metadata (3 file, +5/−5), a basso rischio. Ho verificato puntualmente ogni affermazione e tutto risulta corretto. Verifiche effettuate
🔎 Osservazioni minori (non bloccanti)
📝 Note di processo
Buono per il tag |
There was a problem hiding this comment.
Code Review
This pull request updates the CI workflow documentation in the changelog, adjusts line count statistics and updates relative links to absolute GitHub URLs in the 2.0.0 release notes, and bumps the package-lock.json version to 2.0.0. The reviewer suggested pointing the absolute URLs in the release notes to the static v2.0.0 tag instead of the mutable main branch to ensure long-term consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| --- | ||
|
|
||
| *Full technical changelog: [`CHANGELOG.md`](../../CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](../superpowers/).* | ||
| *Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/main/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/main/docs/superpowers/).* |
There was a problem hiding this comment.
Since these are release notes specifically for the v2.0.0 release, the absolute URLs should point to the static v2.0.0 tag instead of the mutable main branch. This ensures that future updates to the main branch do not drift or break the context of these links for users viewing the v2.0.0 release notes.
| *Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/main/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/main/docs/superpowers/).* | |
| *Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/v2.0.0/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/v2.0.0/docs/superpowers/).* |
There was a problem hiding this comment.
Fixed. Both footer links now point at the immutable v2.0.0 tag (/blob/v2.0.0/CHANGELOG.md and /tree/v2.0.0/docs/superpowers/) instead of main, so the v2.0.0 release notes won't drift. The tag is cut from this same commit, so the links resolve once the release is created. c70ef99
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull request overview
Pre-release housekeeping for the upcoming v2.0.0 GitHub release, addressing issues surfaced by a release-readiness audit (version consistency, release-note accuracy, and link integrity) and aligning release documentation with the CI workflow.
Changes:
- Bumps
package-lock.jsonversion fields to 2.0.0 to match the already-updatedpackage.json. - Updates
docs/releases/2.0.0.mdto correct reported refactor line-counts and to replace broken relative links with absolute GitHub URLs. - Tweaks the
CHANGELOG.mdCI note to mention typechecking in addition to tests.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package-lock.json | Aligns lockfile version metadata with v2.0.0 release versioning. |
| docs/releases/2.0.0.md | Fixes release note accuracy (line counts) and replaces relative links with absolute URLs for release-body rendering. |
| CHANGELOG.md | Updates the documented CI command sequence to include typecheck. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## 🔧 Under the hood | ||
|
|
||
| - Shared `skills/_shared/veo-core/` library (auth, api, validation, pricing, generate, image-helpers). `veo-generate.ts` (595→46 lines) and `veo-multi-generate.ts` (637→36) are now thin entry points over `@veo-core/*`. | ||
| - Shared `skills/_shared/veo-core/` library (auth, api, validation, pricing, generate, image-helpers). `veo-generate.ts` (594→55 lines) and `veo-multi-generate.ts` (635→33) are now thin entry points over `@veo-core/*`. |
There was a problem hiding this comment.
Checked this three ways and the counts are 55 / 33, not 56 / 34: wc -l = 55, grep -c '' = 55 (counts a final unterminated line too), and the last byte of each file IS a newline — so there's no off-by-one from a missing trailing newline. The shebang is line 1 and the last content line is 55 (33 for the multi-shot entry). The CI review job (claude[bot]) also independently reports 55 / 33. Leaving 594→55 / 635→33 as-is. If you counted 56, it may be an editor showing a phantom trailing empty line.
…review) - Release-notes footer links now point at the immutable v2.0.0 tag instead of main (gemini + Copilot): version-specific notes should not drift as main moves. The tag is created from this same commit, so the links resolve once the release is cut. - CHANGELOG CI note: '`npm ci` + `npm run typecheck` + `npm test`' wasn't a runnable command; changed to '`npm ci && npm run typecheck && npm test`' (Copilot). Line-count claim (594->55 / 635->33) left as-is: verified 55/33 via wc -l, grep -c '', and a present trailing newline; Copilot's 56/34 is off by one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude finished @GiuseppeIuculano's task in 58s —— View job Review PR #10 — release-prep v2.0.0 (re-review post c70ef99)
✅ Esito: approvabile — pronto per il tag
|
| Affermazione | Verifica | Esito |
|---|---|---|
Conteggi 594→55 / 635→33 |
wc -l su HEAD: veo-generate.ts = 55, veo-multi-generate.ts = 33 — i valori after combaciano |
✅ |
Nota CI CHANGELOG.md:20 |
.github/workflows/test.yml → npm ci · npm run typecheck · npm test; la riga ora è copia-incollabile e fedele ai 3 step |
✅ |
| Link footer release notes | puntano al tag immutabile /blob/v2.0.0/... e /tree/v2.0.0/... — niente più drift su main |
✅ |
docs/superpowers/ |
la cartella esiste (plans/, specs/) → il link risolve una volta creato il tag |
✅ |
| Coerenza versioni 2.0.0 | package.json = 2.0.0, .claude-plugin/plugin.json = 2.0.0, package-lock.json ora 2.0.0 (solo le 2 righe version, albero dipendenze intatto) |
✅ |
🔎 Osservazioni minori (non bloccanti)
-
Copilot 56/34 vs note 55/33. La differenza è solo la convenzione di conteggio: i file non hanno newline finale, quindi
wc -lriporta 55/33. Le note usano coerentemente i valoriwc -l, scelta legittima — nessuna azione richiesta. -
Tag
v2.0.0non ancora presente (git tagvuoto). I link footer risolveranno solo dopo la creazione della release dallo stesso commit; assicurati di taggare prima di pubblicare il corpo della release. Stessa nota per i before (594/635): plausibili ma non confrontabili con una baseline taggata dato che non esiste unv1.0.0. -
Fraseggio CI tra documenti.
docs/releases/2.0.0.md:83descrive la CI come «tsc --noEmittypecheck + the unit-test suite», mentreCHANGELOG.md:20ora elenca i 3 comandi. Entrambe corrette; valuta solo se uniformare per parità — opzionale.
📝 Note di processo
- Nessun impatto su sicurezza, correttezza, performance o test: il PR non tocca codice.
tsc --noEmitpulito e 219/219 test riportati dall'autore. - Vincolo
CLAUDE.md(test + typecheck verdi prima del commit) rispettato: modifiche limitate a doc/lockfile, nessuna regressione.
Buon lavoro — 👍 per v2.0.0.
· chore/release-2.0.0-prep
Pre-release fixes found by a release-readiness audit (4 parallel verifiers: version-consistency, notes-accuracy, link-integrity, changelog-consistency) before cutting the public v2.0.0 GitHub release.
Blockers fixed
package-lock.jsonstill at1.0.0package.json/plugin.json2.0.0npm version 2.0.0 --no-git-tag-version --allow-same-version→ only the two version lines change; dependency tree untoucheddocs/releases/2.0.0.md:80said595→46/637→36; actual files are 55 / 33 lines594→55and635→33(verified vsv1.0.0baseline + HEAD)docs/releases/2.0.0.md:99used../../CHANGELOG.mdand../superpowers/(relative paths don't resolve in a release body)github.com/.../blob/main/...and/tree/main/...URLsNit
CHANGELOG.md:20CI line saidnpm ci && npm testbut.github/workflows/test.ymlalso runsnpm run typecheck— added for parity with the release notes.Verification
npx tsc --noEmitclean ·npx vitest run219/219This is the last step before tagging
v2.0.0onmain.🤖 Generated with Claude Code