Skip to content

chore: release-prep fixes for v2.0.0 (audit blockers)#10

Merged
GiuseppeIuculano merged 2 commits into
mainfrom
chore/release-2.0.0-prep
Jun 18, 2026
Merged

chore: release-prep fixes for v2.0.0 (audit blockers)#10
GiuseppeIuculano merged 2 commits into
mainfrom
chore/release-2.0.0-prep

Conversation

@GiuseppeIuculano

Copy link
Copy Markdown
Member

Pre-release fixes found by a release-readiness audit (4 parallel verifiers: version-consistency, notes-accuracy, link-integrity, changelog-consistency) before cutting the public v2.0.0 GitHub release.

Blockers fixed

# Blocker Evidence Fix
1 package-lock.json still at 1.0.0 lines 3 (top-level) + 9 (root package entry) — contradicts package.json/plugin.json 2.0.0 npm version 2.0.0 --no-git-tag-version --allow-same-version → only the two version lines change; dependency tree untouched
2 Stale line-count claims in release notes docs/releases/2.0.0.md:80 said 595→46 / 637→36; actual files are 55 / 33 lines corrected to 594→55 and 635→33 (verified vs v1.0.0 baseline + HEAD)
3 Release-body links break on the Releases page docs/releases/2.0.0.md:99 used ../../CHANGELOG.md and ../superpowers/ (relative paths don't resolve in a release body) converted to absolute github.com/.../blob/main/... and /tree/main/... URLs

Nit

  • CHANGELOG.md:20 CI line said npm ci && npm test but .github/workflows/test.yml also runs npm run typecheck — added for parity with the release notes.

Verification

  • npx tsc --noEmit clean · npx vitest run 219/219
  • All other audit dimensions: ready (version statements consistent at 2.0.0 everywhere else; breaking changes / new features / verified-live claims all accurate vs code; CHANGELOG ↔ release-notes consistent).

This is the last step before tagging v2.0.0 on main.

🤖 Generated with Claude Code

A release-readiness audit (4 parallel verifiers) found three blockers that
would make the v2.0.0 public release inaccurate or broken:

- package-lock.json still declared version 1.0.0 (top-level + root package
  entry); synced to 2.0.0 via 'npm version --no-git-tag-version' (only the two
  version lines change; dependency tree untouched).
- docs/releases/2.0.0.md line-count claims were stale: 'veo-generate.ts
  595->46' and 'veo-multi-generate.ts 637->36'. Actual, verified against the
  v1.0.0 baseline and HEAD: 594->55 and 635->33.
- docs/releases/2.0.0.md footer linked CHANGELOG.md and docs/superpowers/ with
  relative paths (../../, ../) that break when the file is rendered as a GitHub
  release body. Converted to absolute github.com URLs.

Also (nit): CHANGELOG.md CI line said 'npm ci && npm test' but the workflow
also runs 'npm run typecheck' — added it for parity with the release notes.

npm test 219/219, tsc --noEmit clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 18, 2026 09:00
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: addeb703-da7f-4468-983f-54b0927de7df

📥 Commits

Reviewing files that changed from the base of the PR and between 946c897 and c70ef99.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • docs/releases/2.0.0.md
✅ Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • docs/releases/2.0.0.md

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Aggiunto il type checking al flusso di integrazione continua per i PR su main, prima dell’esecuzione dei test.
  • Documentation

    • Aggiornate le sezioni “Under the hood” in base alle descrizioni più recenti degli entry point sottili sopra @veo-core/*.
    • Sistemati link e destinazioni della documentazione di rilascio (incluso il “Full technical changelog”).

Walkthrough

Due file di documentazione vengono aggiornati: CHANGELOG.md aggiunge npm run typecheck al comando CI per le PR verso main; docs/releases/2.0.0.md corregge le metriche di riduzione del codice per veo-generate.ts e veo-multi-generate.ts e converte il link al changelog tecnico da percorso relativo a URL GitHub assoluto.

Changes

Correzioni documentazione 2.0.0

Layer / File(s) Sommario
Correzioni CHANGELOG e release note 2.0.0
CHANGELOG.md, docs/releases/2.0.0.md
CHANGELOG.md aggiunge il passo npm run typecheck nel flusso CI documentato. docs/releases/2.0.0.md aggiorna le dimensioni documentate degli entry point veo-generate.ts e veo-multi-generate.ts e sostituisce il link al changelog tecnico con un URL GitHub assoluto.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • copilot-pull-request-reviewer

Poem

🐇 Un coniglio saltella tra le righe del doc,
aggiunge un typecheck con un piccolo boc!
I numeri corretti, i link ora assoluti,
nessun bug nascosto tra i testi perduti.
La tana è in ordine, tutto a posto così! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Il titolo è specifico e descrive accuratamente i principali cambiamenti della PR: correzioni pre-release per la versione 2.0.0 e blocchi dell'audit.
Description check ✅ Passed La descrizione è dettagliata e completamente correlata ai changeset, documentando i tre blocchi risolti e la verifica dei test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-2.0.0-prep
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/release-2.0.0-prep

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Claude finished @GiuseppeIuculano's task in 1m 19s —— View job


Review PR #10 — release-prep v2.0.0

  • Analisi diff e contesto
  • Verifica conteggi righe (594→55 / 635→33)
  • Verifica coerenza versioni e link
  • Verifica nota CI (CHANGELOG ↔ workflow)
  • Pubblicazione review

✅ Esito: approvabile

PR di sola documentazione/metadata (3 file, +5/−5), a basso rischio. Ho verificato puntualmente ogni affermazione e tutto risulta corretto.

Verifiche effettuate

Affermazione Verifica Esito
package-lock.json → 2.0.0 coerente con package.json e .claude-plugin/plugin.json (entrambi 2.0.0); modificate solo le 2 righe version, albero dipendenze intatto
Conteggi righe 594→55 / 635→33 wc -l su HEAD: veo-generate.ts = 55, veo-multi-generate.ts = 33 ✅ (valori after confermati)
Nota CI in CHANGELOG.md:20 .github/workflows/test.yml esegue npm cinpm run typechecknpm test: la riga ora rispecchia esattamente i 3 step
Link docs/superpowers/ la cartella esiste (plans/, specs/) → il link assoluto risolve
Conversione link a URL assoluti scelta corretta: i path relativi non risolvono nel corpo di una GitHub Release

🔎 Osservazioni minori (non bloccanti)

  1. Baseline 594/635 non verificabile da tag. Non esiste ancora un tag v1.0.0 nel repo (git tag è vuoto), quindi i valori before citati nelle note non sono confrontabili con una baseline taggata. I valori after (55/33) sono confermati su HEAD, e i before sono comunque plausibili — segnalo solo per trasparenza, dato che il PR menziona «verified vs v1.0.0 baseline».

  2. Coerenza con docs/releases/2.0.0.md:80. La riga delle note recita «CI workflow: tsc --noEmit typecheck + the unit-test suite», mentre il CHANGELOG.md ora elenca npm ci + npm run typecheck + npm test. Entrambe corrette, formulazioni diverse: ok così, ma valuta se uniformare il fraseggio per parità tra i due documenti.

📝 Note di processo

  • Nessun problema su sicurezza, correttezza, performance o test (il PR non tocca codice; tsc --noEmit pulito e 219/219 test riportati dall'autore).
  • CLAUDE.md impone npm test + npx tsc --noEmit verdi prima del commit: trattandosi di sole modifiche a doc/lockfile è rispettato e non introduce regressioni.

Buono per il tag v2.0.0. 👍
· chore/release-2.0.0-prep

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI workflow documentation in the changelog, adjusts line count statistics and updates relative links to absolute GitHub URLs in the 2.0.0 release notes, and bumps the package-lock.json version to 2.0.0. The reviewer suggested pointing the absolute URLs in the release notes to the static v2.0.0 tag instead of the mutable main branch to ensure long-term consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/releases/2.0.0.md Outdated
---

*Full technical changelog: [`CHANGELOG.md`](../../CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](../superpowers/).*
*Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/main/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/main/docs/superpowers/).*

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since these are release notes specifically for the v2.0.0 release, the absolute URLs should point to the static v2.0.0 tag instead of the mutable main branch. This ensures that future updates to the main branch do not drift or break the context of these links for users viewing the v2.0.0 release notes.

Suggested change
*Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/main/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/main/docs/superpowers/).*
*Full technical changelog: [`CHANGELOG.md`](https://github.com/CTMobi/veo-tools/blob/v2.0.0/CHANGELOG.md). Design spec and implementation plan under [`docs/superpowers/`](https://github.com/CTMobi/veo-tools/tree/v2.0.0/docs/superpowers/).*

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Both footer links now point at the immutable v2.0.0 tag (/blob/v2.0.0/CHANGELOG.md and /tree/v2.0.0/docs/superpowers/) instead of main, so the v2.0.0 release notes won't drift. The tag is cut from this same commit, so the links resolve once the release is created. c70ef99

@codacy-production

codacy-production Bot commented Jun 18, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pre-release housekeeping for the upcoming v2.0.0 GitHub release, addressing issues surfaced by a release-readiness audit (version consistency, release-note accuracy, and link integrity) and aligning release documentation with the CI workflow.

Changes:

  • Bumps package-lock.json version fields to 2.0.0 to match the already-updated package.json.
  • Updates docs/releases/2.0.0.md to correct reported refactor line-counts and to replace broken relative links with absolute GitHub URLs.
  • Tweaks the CHANGELOG.md CI note to mention typechecking in addition to tests.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
package-lock.json Aligns lockfile version metadata with v2.0.0 release versioning.
docs/releases/2.0.0.md Fixes release note accuracy (line counts) and replaces relative links with absolute URLs for release-body rendering.
CHANGELOG.md Updates the documented CI command sequence to include typecheck.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/releases/2.0.0.md
## 🔧 Under the hood

- Shared `skills/_shared/veo-core/` library (auth, api, validation, pricing, generate, image-helpers). `veo-generate.ts` (595→46 lines) and `veo-multi-generate.ts` (637→36) are now thin entry points over `@veo-core/*`.
- Shared `skills/_shared/veo-core/` library (auth, api, validation, pricing, generate, image-helpers). `veo-generate.ts` (594→55 lines) and `veo-multi-generate.ts` (635→33) are now thin entry points over `@veo-core/*`.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this three ways and the counts are 55 / 33, not 56 / 34: wc -l = 55, grep -c '' = 55 (counts a final unterminated line too), and the last byte of each file IS a newline — so there's no off-by-one from a missing trailing newline. The shebang is line 1 and the last content line is 55 (33 for the multi-shot entry). The CI review job (claude[bot]) also independently reports 55 / 33. Leaving 594→55 / 635→33 as-is. If you counted 56, it may be an editor showing a phantom trailing empty line.

Comment thread docs/releases/2.0.0.md Outdated
Comment thread CHANGELOG.md Outdated
…review)

- Release-notes footer links now point at the immutable v2.0.0 tag instead of
  main (gemini + Copilot): version-specific notes should not drift as main
  moves. The tag is created from this same commit, so the links resolve once
  the release is cut.
- CHANGELOG CI note: '`npm ci` + `npm run typecheck` + `npm test`' wasn't a
  runnable command; changed to '`npm ci && npm run typecheck && npm test`'
  (Copilot).

Line-count claim (594->55 / 635->33) left as-is: verified 55/33 via wc -l,
grep -c '', and a present trailing newline; Copilot's 56/34 is off by one.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Claude finished @GiuseppeIuculano's task in 58s —— View job


Review PR #10 — release-prep v2.0.0 (re-review post c70ef99)

  • Analisi diff aggiornato
  • Verifica conteggi righe (594→55 / 635→33)
  • Verifica link tag v2.0.0 e comando CI
  • Coerenza CHANGELOG ↔ workflow ↔ release notes
  • Pubblicazione review

✅ Esito: approvabile — pronto per il tag v2.0.0

PR di sola documentazione/metadata (3 file, +5/−5). Ho ri-verificato puntualmente ogni affermazione sull'ultimo commit c70ef99 e tutto torna. I feedback di Gemini e Copilot sui link a main sono già stati risolti (link ora all'immutabile tag v2.0.0).

Verifiche effettuate

Affermazione Verifica Esito
Conteggi 594→55 / 635→33 wc -l su HEAD: veo-generate.ts = 55, veo-multi-generate.ts = 33 — i valori after combaciano
Nota CI CHANGELOG.md:20 .github/workflows/test.ymlnpm ci · npm run typecheck · npm test; la riga ora è copia-incollabile e fedele ai 3 step
Link footer release notes puntano al tag immutabile /blob/v2.0.0/... e /tree/v2.0.0/... — niente più drift su main
docs/superpowers/ la cartella esiste (plans/, specs/) → il link risolve una volta creato il tag
Coerenza versioni 2.0.0 package.json = 2.0.0, .claude-plugin/plugin.json = 2.0.0, package-lock.json ora 2.0.0 (solo le 2 righe version, albero dipendenze intatto)

🔎 Osservazioni minori (non bloccanti)

  1. Copilot 56/34 vs note 55/33. La differenza è solo la convenzione di conteggio: i file non hanno newline finale, quindi wc -l riporta 55/33. Le note usano coerentemente i valori wc -l, scelta legittima — nessuna azione richiesta.

  2. Tag v2.0.0 non ancora presente (git tag vuoto). I link footer risolveranno solo dopo la creazione della release dallo stesso commit; assicurati di taggare prima di pubblicare il corpo della release. Stessa nota per i before (594/635): plausibili ma non confrontabili con una baseline taggata dato che non esiste un v1.0.0.

  3. Fraseggio CI tra documenti. docs/releases/2.0.0.md:83 descrive la CI come «tsc --noEmit typecheck + the unit-test suite», mentre CHANGELOG.md:20 ora elenca i 3 comandi. Entrambe corrette; valuta solo se uniformare per parità — opzionale.

📝 Note di processo

  • Nessun impatto su sicurezza, correttezza, performance o test: il PR non tocca codice. tsc --noEmit pulito e 219/219 test riportati dall'autore.
  • Vincolo CLAUDE.md (test + typecheck verdi prima del commit) rispettato: modifiche limitate a doc/lockfile, nessuna regressione.

Buon lavoro — 👍 per v2.0.0.
· chore/release-2.0.0-prep

@GiuseppeIuculano
GiuseppeIuculano merged commit d172231 into main Jun 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants