Refactor Events#14

Merged

CSSFrancis merged 43 commits into

mainfrom

refactor/project-reorganization

May 20, 2026

Commits on May 18, 2026

feat: add pointer_settled dwell timer to JS — zero cost when unused, per-panel ms/delta from state
CSSFrancis
committed
docs: add event system redesign spec
CSSFrancis
committed
docs: add event system implementation plan
CSSFrancis
committed
refactor: flatten Event dataclass — all payload fields are typed top-level attrs
CSSFrancis
committed
test: add stop_propagation repr test and dx/dy assertions to TestEvent
CSSFrancis
committed
refactor: rewrite CallbackRegistry with priority, wildcard, disconnect_fn, stop_propagation
CSSFrancis
committed
feat: add pause_events and hold_events context managers to CallbackRegistry
CSSFrancis
committed
feat: add _EventMixin with add_event_handler, remove_handler, pause/hold_events
CSSFrancis
committed
refactor: update _dispatch_event and Widget._update_from_js to use flat Event fields
CSSFrancis
committed
refactor: Plot1D/2D/3D/Bar and PlotMesh adopt _EventMixin, remove old on_* decorators and registered_keys
CSSFrancis
committed
refactor: Widget adopts _EventMixin, remove old on_changed/on_release/on_click/disconnect; update tests
CSSFrancis
committed
fix: remove on_line_click/on_line_hover from VALID_EVENT_TYPES; use pointer_down in line tests
CSSFrancis
committed
fix: update inset tests to use renamed inset_state_change event type
CSSFrancis
committed
feat: JS forwards pointer_up, pointer_enter/leave, double_click, wheel, key_up; rename event types and fields; remove registered_keys filtering
CSSFrancis
committed
fix: remove duplicate mouseleave and dblclick listeners in _attachEvents2d
CSSFrancis
committed
fix: correct button null guard in _pointerFields, fix key_down x/y undefined, clean stale comments
CSSFrancis
committed
feat: add pointer_settled dwell timer to JS — zero cost when unused, per-panel ms/delta from state
CSSFrancis
committed
fix: snapshot performance.now() once in pointer_settled callback; clear stale timers on mousemove early returns; capture modifiers at arm time
CSSFrancis
committed
test: add Playwright tests for pointer events, pointer_settled, and pause/hold integration
CSSFrancis
committed
fix: add button=0 assertion to double_click test; fix 3d no-xdata test; add delta=0 assertion
CSSFrancis
committed
refactor: extract shared event test helpers; fix 3d no-pointer_down positive assertion
CSSFrancis
committed
test: add regression tests confirming old event API removed; update Examples if needed
CSSFrancis
committed
refactor: replace event.data dict access with widget attribute access in Examples
CSSFrancis
committed
fix: use event.source.x in widget handlers; remove duplicate regression test; add Plot3D/Bar coverage
CSSFrancis
committed
fix: delete dead Line1D.on_hover shim; add regression tests for Line1D
CSSFrancis
committed
fix: replace event.img_x/img_y with event.xdata/ydata in Examples
CSSFrancis
committed
fix: _pointerFields always null button; pointer_down/up explicitly set button: e.button
CSSFrancis
committed
fix: PlotBar pointer_down on mousedown (was click); emit bar_index: null on miss
CSSFrancis
committed
refactor. Removed plans
CSSFrancis
committed
fix: address PR review comments — last_widget_id field, x/y float types, remove_handler guard, unused import
CSSFrancis
committed
docs: add events.rst — event system guide with Matplotlib/pygfx compare and implementation-status table
CSSFrancis
committed
test: fix flaky test_fires_again_after_re_settle — poll with wait_for_function instead of fixed sleep
CSSFrancis
committed
feat: add plot_particle_picker.py EM interactive example
CSSFrancis
committed
feat: add plot_eels_explorer.py EM interactive example
CSSFrancis
committed
feat: add plot_threshold_explorer.py EM interactive example
CSSFrancis
committed
feat: add plot_roi_inspector.py EM interactive example
CSSFrancis
committed
test: add smoke tests for interactive EM example scripts
CSSFrancis
committed
fix: add xdata/ydata None guards in all EM example event handlers
CSSFrancis
committed