Skip to content

fix: updater #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeMaster4711 merged 1 commit into from
Jan 17, 2026
Merged

fix: updater #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions backend/src/routes/updates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,18 @@ pub async fn install_update(

command
.arg(&version_clone)
// Redirect stdout/stderr to /dev/null since we detach
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null());
// Redirect stdout/stderr to log file for debugging
.stdin(std::process::Stdio::null());

// Keep stdout/stderr open so we can see errors in the log
// The script itself redirects to /var/tmp/csf-core-update.log

tracing::info!("Executing command: {:?}", command);
tracing::info!(
"Command environment: PATH={}, HOME={}",
std::env::var("PATH").unwrap_or_default(),
std::env::var("HOME").unwrap_or_default()
);

match command.spawn() {
Ok(child) => {
Expand Down
2 changes: 2 additions & 0 deletions csf-core.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ Environment="ORIGIN=http://localhost:8000"
PrivateTmp=true
ProtectSystem=strict
ProtectHome=true
NoNewPrivileges=false
ReadWritePaths=/opt/csf-core
ReadWritePaths=/var/lib/csf-core
ReadWritePaths=/var/log/csf-core
ReadWritePaths=/tmp
ReadWritePaths=/var/tmp
SupplementaryGroups=docker

# Startup: Use unified startup script
Expand Down
3 changes: 3 additions & 0 deletions csf-core.sudoers
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ csf-core ALL=(ALL) NOPASSWD: /bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /usr/bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /usr/bin/nohup /bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /usr/bin/nohup /usr/bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /usr/bin/nohup sudo /bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /bin/nohup /bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /usr/bin/sudo /usr/bin/nohup /bin/bash /opt/csf-core/scripts/update.sh*
csf-core ALL=(ALL) NOPASSWD: /bin/systemctl daemon-reload
csf-core ALL=(ALL) NOPASSWD: /bin/systemctl start csf-core.service
csf-core ALL=(ALL) NOPASSWD: /bin/systemctl stop csf-core.service
Expand Down
12 changes: 12 additions & 0 deletions scripts/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ REPO="CS-Foundry/CSF-Core"
INSTALL_DIR="/opt/csf-core"
# Use /var/tmp instead of /tmp to avoid systemd PrivateTmp isolation
STATUS_FILE="/var/tmp/csf-core-update-status.json"
LOG_FILE="/var/tmp/csf-core-update.log"

# Redirect all output to log file (and still show on console)
exec > >(tee -a "${LOG_FILE}") 2>&1

echo "[$(date +'%Y-%m-%d %H:%M:%S')] ========================================"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] CSF-Core Update Script Started"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] Version: ${VERSION}"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] User: $(whoami)"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] UID: $EUID"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] PWD: $(pwd)"
echo "[$(date +'%Y-%m-%d %H:%M:%S')] ========================================"

# Determine if we need sudo early
if [ "$EUID" -eq 0 ]; then
Expand Down
Loading