Removal of variant-related definitions#23
Merged
Conversation
added 5 commits
May 14, 2026 15:27
DDLm version generated from latest local copy of cbf_imgcif_dictionary together with removal of variant category to cif_img_variant dictionary.
Includes local (COMCIFS) fixes to DDL2 dictionary.
vaitkus
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
variantcategory creates a number of problems (e.g. this one and these ones) and is also not incorporated into the main mmCIF dictionary. This PR moves everything related to thevariantcategory intocif_img_variant.dic, and at the same time bases the transformations off a local fork of the DDL2 dictionary.The formatting of the output is slightly shifted due to improvements in output logic in the
CrystalInfoFramework.jl.