Skip to content

add PD_PEAK_PHASE_MAP#283

Draft
rowlesmr wants to merge 5 commits into
COMCIFS:masterfrom
rowlesmr:peaks-to-phase-mapping
Draft

add PD_PEAK_PHASE_MAP#283
rowlesmr wants to merge 5 commits into
COMCIFS:masterfrom
rowlesmr:peaks-to-phase-mapping

Conversation

@rowlesmr

Copy link
Copy Markdown
Collaborator

Allows a mapping of peak to phase for each diffractogram. Three keys, as for any given peak in any given diffractogram, at least one phase will contribute, so phase_id can't simply be a non-key data name

rowlesmr added 5 commits May 18, 2026 21:23
Allows a mapping of peak to phase for each diffractogram. Three keys, as for any given peak in any given diffractogram, at least one phase will contribute.
Didn't alter date, as not a substantive change
and added a revision note
@jamesrhester

Copy link
Copy Markdown
Contributor

Allows a mapping of peak to phase for each diffractogram. Three keys, as for any given peak in any given diffractogram, at least one phase will contribute, so phase_id can't simply be a non-key data name

I think of it like a peak and a diffractogram are not enough to uniquely determine phase as more than one phase could contribute.

What I'm not sure about here is the reason for this category. Any reflection appearing in REFLN will have a phase, diffractogram and peak associated with it.

Maybe this category is for assigning phases to peaks where no indexing has been done?

@rowlesmr

Copy link
Copy Markdown
Collaborator Author

Maybe this category is for assigning phases to peaks where no indexing has been done?

Yes. If there is no mapping of peak <-> refln, this provides a way to assign peak to phase.

@rowlesmr

rowlesmr commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

I'm downgrading this to a draft pr, given that we have incoming corrections for publication.

Also, refln data means can be used to do the same thing

@rowlesmr rowlesmr marked this pull request as draft July 5, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants