fix PD_AMORPHOUS keys#281
Merged
Merged
Conversation
Collaborator
Author
|
Semantic checks failed: Those dates are in the future? |
Collaborator
|
@rowlesmr I think it was I who decided to accidentally time travel in my last PR. Just ignore this for now, I will create a separate PR to fix it. |
Collaborator
Author
|
No dramas :) |
Collaborator
|
@rowlesmr Should be fixed in master branch now. |
From COMCIFS/cif_core_multiblock#42. Insufficient information was recorded to correctly identify the linked PD_PEAK from the PD_AMORPHOUS information.
6ab75c0 to
77f20a9
Compare
Collaborator
Author
|
CI failures are dictionary metadata-related. |
Collaborator
|
@rowlesmr This is a known issue, feel free to ignore it for now. :) |
Add example data for pd_amorphous and peak details.
Collaborator
Author
|
Also, merging this will probably allow for #124 to be closed, as every category will (hopefully) have examples. |
jamesrhester
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From COMCIFS/cif_core_multiblock#42 and #275
Insufficient information was recorded to correctly identify the linked
PD_PEAKfrom thePD_AMORPHOUSinformation.Added
_pd_amorphous.diffractogram_id. Removed_pd_amorphous.phase_id, as an amorphous peak (or any peak) could belong to more than one phase.