add _refln.structure_id#64
Open
rowlesmr wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@jamesrhester It was easier to redo than untangle |
jamesrhester
reviewed
Jul 2, 2026
jamesrhester
left a comment
jamesrhester
left a comment
Contributor
There was a problem hiding this comment.
The cif_ms dictionary does not need to restate the _refln.structure_id definition, as that is already provided by the multiblock dictionary. It only needs to restate the REFLN category definition because the human-readable text has been adjusted to alert the reader to the presence of more hkls, otherwise the REFLN definition from the multiblock dictionary would also be sufficient.
Removed the definition of _refln.structure_id -> its already defined in CIF_MULTI. Just need to add it as a category key here.
jamesrhester
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originally #45 before the commit history got out of wack.