added keys and links to cell_wave_vector and cell_wave_vectors#60
Open
rowlesmr wants to merge 7 commits into
Open
added keys and links to cell_wave_vector and cell_wave_vectors#60rowlesmr wants to merge 7 commits into
cell_wave_vector and cell_wave_vectors#60rowlesmr wants to merge 7 commits into
Conversation
Contributor
Author
|
I have no idea how this PR is 1000 lines... Will have to go and check |
Contributor
It seems to fold in a number of your other PRs as well. Not sure what's going on on your side, but I usually create a fresh branch from the current main for each PR. To save work you can cherry-pick the particular commit that corresponds to what you thought this PR was supposed to do. |
Contributor
Author
|
Must have done a merge the wrong way somehow. |
Contributor
Author
|
@jamesrhester @gmadaria please excuse the mangled commit history, but it's back on track |
jamesrhester
approved these changes
Jul 10, 2026
no idea how that happened.... Now should just be cel_vector(s) related
I should have just started again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussion in #54
cell_wave_vector(Loop) gains:Setkey to_structure.id: so we know the structure to which the vectors belong_cell_wave_vectors.id: so we know the conditions under which the vectors were measured. I took inspiration frompd_peakandpd_peak_overall.cell_wave_vectors(Set) gains:_cell_wave_vectors.idto uniquely identify the conditions