Skip to content

Added atom_sites_* structure id key#53

Open
rowlesmr wants to merge 7 commits into
COMCIFS:mainfrom
rowlesmr:ATOM_SITES_-structure-key
Open

Added atom_sites_* structure id key#53
rowlesmr wants to merge 7 commits into
COMCIFS:mainfrom
rowlesmr:ATOM_SITES_-structure-key

Conversation

@rowlesmr

@rowlesmr rowlesmr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Added linked key *.structure_id data names to ATOM_SITES_AXES, ATOM_SITES_MODULATION, and ATOM_SITES_ORTHO.

Did not add to ATOM_SITES_DISPLACE_FOURIER, as it is a deprecated category - see #50
Did not add to ATOM_SITES_ROT_FOURIER, as it is a deprecated category
Can be added if needed.

@rowlesmr

Copy link
Copy Markdown
Contributor Author

ATOM_SITES_ROT_FOURIER has no keys at all, and consists of only one deprecated data name. Category should be deprecated. cf #50

@jamesrhester

Copy link
Copy Markdown
Contributor

Same comment as on #45 : should we add a short phrase to the *.structure_id data names to state that they can be omitted?

rowlesmr added 2 commits June 30, 2026 14:01
Added notes about omitting structure_id when only one _structure.id is present.
@rowlesmr

rowlesmr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Same comment as on #45 : should we add a short phrase to the *.structure_id data names to state that they can be omitted?

already done for ATOM_SITES_AXES, ATOM_SITES_MODULATION, and ATOM_SITES_ORTHO

@rowlesmr

rowlesmr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Some changes got smushed somehow. Put them back in.

@rowlesmr

rowlesmr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Did not add to ATOM_SITES_DISPLACE_FOURIER, as it is a deprecated category - see #50 Can be added if needed.
Did not add to ATOM_SITES_ROT_FOURIER, as it is a deprecated category

Should it be added here for backwards compatibility?

@jamesrhester

Copy link
Copy Markdown
Contributor

Should it be added here for backwards compatibility?

No. No legacy software knows about _structure.id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants