Skip to content

Add linked structure_id definition save frame#16

Merged
jamesrhester merged 5 commits into
COMCIFS:mainfrom
rowlesmr:add-structure-id
Jul 10, 2026
Merged

Add linked structure_id definition save frame#16
jamesrhester merged 5 commits into
COMCIFS:mainfrom
rowlesmr:add-structure-id

Conversation

@rowlesmr

@rowlesmr rowlesmr commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

To aid in defining linked structure_id data names in dictionaries.

@rowlesmr

rowlesmr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

The description is wrong.

The capacity to elide a data name is dependent on it being a category key.

They're are use-cases where this is not the case; cf _model.structure_id

@jamesrhester

jamesrhester commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

The description is wrong.

The capacity to elide a data name is dependent on it being a category key.

They're are use-cases where this is not the case; cf _model.structure_id

Yes, this save frame should only be for those data names that are keys. The ones that are not keys are worth keeping in full in the main dictionary, I'd say. And also, it can't be used for those data names that are in child categories and should refer to the equivalent key in their parent category instead of _structure.id

@rowlesmr

rowlesmr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

this save frame should only be for those data names that are keys.

maybe, saveframe name: "structure_id_key"?

I'll make a commit, feel free to revert

@jamesrhester

Copy link
Copy Markdown
Collaborator

There could be a second template save frame for the "must-link-to-parent-category-structure-id" case which leaves out the _name.linked_item_id entry.

@rowlesmr

rowlesmr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Will investigate tonight

rowlesmr added 2 commits July 9, 2026 17:14
To indicate that it is only to be used in data names used as category keys
@rowlesmr rowlesmr requested a review from jamesrhester July 9, 2026 11:19
@rowlesmr

rowlesmr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Maybe better:

"The structure to which this category relates."

@jamesrhester

Copy link
Copy Markdown
Collaborator

Maybe better:

"The structure to which this category relates."

Actually, yes, that makes more sense.

@rowlesmr

Copy link
Copy Markdown
Contributor Author

Should be good for merging now. Also to stop some check failures in other dictionaries.

@jamesrhester jamesrhester merged commit 05af8fd into COMCIFS:main Jul 10, 2026
1 check passed
@rowlesmr rowlesmr deleted the add-structure-id branch July 10, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants