POC: Authorize with ID.me, remove devise gems#2997
Merged
Conversation
… into jd/dpc-5127-multiple-oidc
lukey-luke
reviewed
Jun 16, 2026
| login_dot_gov_signin_cancel_text: Login.gov sign-in was unsuccessful. If this was an error, try signing in again. | ||
| login_dot_gov_signin_fail_status: Login.gov sign-in failed | ||
| login_dot_gov_signin_fail_text: Something went wrong while trying to sign-in with Login.gov. Please try again. | ||
| id_me_signin_cancel_status: ID.me sign-in incomplete |
Contributor
There was a problem hiding this comment.
I think we'll want to have a separate ticket for error messages, but I wanted to flag that we can probably parameterize this and re-use across CSP's
e.g.
Something went wrong while trying to sign in with %{csp}. Please try again.
Merged
manojwadhwa81
approved these changes
Jun 17, 2026
Comment on lines
+61
to
+72
| def handle_invitation_flow_failure(invitation_id) | ||
| Rails.logger.info(['Failed invitation flow', | ||
| { actionContext: LoggingConstants::ActionContext::Registration, | ||
| actionType: LoggingConstants::ActionType::FailedLogin, | ||
| **csp_log_context }]) | ||
| invitation = Invitation.find(invitation_id) | ||
| if invitation.credential_delegate? | ||
| render(Page::Utility::ErrorComponent.new(invitation, 'fail_to_proof'), status: :forbidden) | ||
| else | ||
| render(Page::Invitations::AoFlowFailComponent.new(invitation, 'fail_to_proof', 1), status: :forbidden) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Should this be moved to the invitations_controller?
Contributor
Author
There was a problem hiding this comment.
this is handling an error in the invitation flow specifically in the CSP login step, so it makes more sense here than there, but I think I'm gonna move these handler methods into a separate concern anyway
Comment on lines
+8
to
+10
| def ial_1_user?(auth) | ||
| auth.extra.raw_info.identity_assurance_level.to_i == 1 | ||
| end |
Contributor
There was a problem hiding this comment.
This can probably be moved to the CspController itself. I can probably handle that in my PR or a follow up one though!
manojwadhwa81
approved these changes
Jun 17, 2026
ashley-weaver
merged commit ca5ac8e
into
multi-csp-feature-branch-1
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5368
🛠 Changes
Updates controllers to handle multiple CSPs.
ℹ️ Context
Based off POC for using multiple CSPs.
🧪 Validation
Tested locally with Login.gov and ID.me
Note: This doesn't cover logging out of multiple CSPs. Failing accessibility tests will be resolved in a following ticket.