Joss review fixes - #1
Merged
Merged
Conversation
… JOSS - rename paper/Figures -> paper/figures (case-sensitive Linux build) - BSD-3 -> BSD-2 to match LICENSE; repo URL -> CMC-lab/PyGPLA - add required generative-AI disclosure; fix typos - remove stale paper.html; rebuild paper.pdf - README: real PyPI install, fill Citing section
Add direct tests for coupling matrix, SVD factorization, whitening, spike-jitter surrogates, and config validation (3 -> 32 tests).
- pytest matrix + ruff gate; openjournals draft-pdf workflow - wrap long lines, drop dead vars/imports; scope figure-script E402 - pyproject: real authors, per-file ignores
Clarify in GPLAResult/gpla docstrings and quickstart/usage/examples that p_value is NaN by design for RMT-based; decision is in stats['gPLV_stats'].
The earlier rename silently no-op'd under core.ignorecase=true, leaving git tracking paper/Figures/ (capital) while disk, paper.md, docs, and the ruff per-file-ignore all used lowercase. On Linux CI, ruff then linted the capital path, missing the E402 ignore. Force the index to lowercase to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.