amending interview control variables - #4
Conversation
|
Hi @mnfurey25, this is marked as a draft. I assume that indicates it's not quite ready yet? |
|
Hi @travissouthard, thank you so much! I recently added a few more commits, that makes this PR ready to review, including some questions for the review answers page. I can remove the draft label and follow up with another PR that extends the review answers page. |
travissouthard
left a comment
travissouthard
left a comment
There was a problem hiding this comment.
This is great @mnfurey25! I was especially delighted to see you add to the review section! A lot is moving much more smoothly, but a few notes below.
| yesno: fileAppeal | ||
| --- | ||
| mandatory: fileAppeal == True | ||
| mandatory: fileAppeal |
There was a problem hiding this comment.
I tried answering no to filing an appeal but still landed on this page.
Is that a fluke?
There was a problem hiding this comment.
I am not seeing this behavior with the new template letter for this PR. I changed some variables in the template letter so that the interview did not interpret these as required.
| Appraisal | ||
| subquestion: | | ||
| Generally, an appraisal is a strong basis for an appeal. If you have a recent appraisal showing a lower home value than the City's assessment, you can appeal on that basis alone, and there is no need for you to answer any other questions. However, if you would like to answer other questions, you may do so. | ||
| Generally, an appraisal is a strong basis for an appeal. If you have a recent appraisal showing a lower home value than the City's assessment, you can appeal on that basis alone, and there is no need for you to answer any other questions. However, if you would like to answer other questions, you may do so. | ||
| fields: | ||
| - "Did you have an appraisal within the past 3 years showing a home value lower than the assessed value?": had_appraisal | ||
| datatype: yesnoradio | ||
| - Please upload a picture of your appraisal.: appraisal_document | ||
| datatype: file | ||
| show if: had_appraisal | ||
| - What was the appraisal amount?: appraisal_value | ||
| show if: had_appraisal | ||
| --- |
There was a problem hiding this comment.
If I answered no to "Do you want to file an appeal?" and still filled out the info in the owner info form, answering "no" to having had an appeal freezes it, but answering yes and uploading a document still works.
| * Number of Rooms: ${ home_data['number_of_rooms'] } | ||
| * Number of Stories: ${ home_data['number_stories'] } | ||
| * Fireplaces: ${ home_data['fireplaces'] } | ||
| * Central Air (Y for Yes, N for No): ${ home_data['central_air'] } |
There was a problem hiding this comment.
Rather than adding "(Y for Yes, N for No)" it would be friendlier to have the answer render with ${ "Yes" if home_data["central_air"] == "Y" else "No" } so that it just shows them "Yes" or "No"
There was a problem hiding this comment.
I agree. This was changed with a recent commit.
| - Review Applicant First Name: client.name.first | ||
| button: | | ||
| You said | ||
| ${ client.name.first }. | ||
| - Review Applicant Last Name: client.name.last | ||
| button: | | ||
| You said | ||
| ${ client.name.last }. |
There was a problem hiding this comment.
Thank you for inferring this from answers answers answers! I was delighted to see this.
For each of these, I think it will read easier if we change the button text to:
Applicant First Name: ${ client.name.first }
or
Applicant Last Name: ${ client.name.last }
And without a period at the end just to avoid any visual clutter
There was a problem hiding this comment.
Of course! It made sense to me. :)
I agree, I changed the labels on the buttons with a recent commit.
There was a problem hiding this comment.
In the most recent commit, I removed the "You said" language.
| mandatory: True | ||
| question: | | ||
| Please review your answers | ||
| Sign your name |
There was a problem hiding this comment.
I think this box should be "Please review your answers" rather than "Sign your name"
There was a problem hiding this comment.
I agree. This has been changed with a recent commit.
| --- | ||
| mandatory: True | ||
| code: | | ||
| # insert interview logic here | ||
| all_done | ||
| --- | ||
| question: | | ||
| You have reached the end of the | ||
| interview. | ||
| subquestion: | | ||
| Thank you for your time. | ||
| sets: all_done No newline at end of file |
There was a problem hiding this comment.
I don't think we need these sections, however this may be a good place to send people who answer "No" to filing an appeal
There was a problem hiding this comment.
These sections have been condensed with a recent commit.
| new_dictionary[row["location"]][key] = val | ||
| return new_dictionary | ||
| except TypeError: | ||
| return {} |
There was a problem hiding this comment.
I added handling for address type errors.
b7eb8d5 to
d25c8f6
Compare
2 participants
The following changes interview control variables to order questions and add conditional pages.