Update map app workflow UI - #227
Conversation
|
@quinnylee Issue #216 |
chp2001
left a comment
There was a problem hiding this comment.
This is really cool. Very nice quality of life and streamlining improvement.
I tested it with a few of the model types, and the feedback was somewhat lacking beyond the "complete" identifier, so I'm not completely confident it's doing everything properly, but it runs without errors and seems to do fine.
Nothing really wrong on the code side of things. Some scattered places where there's some refactoring that doesn't change functionality, but for the most part they seem to be improvements.
My primary complaint on this is that you removed some comments, and didn't seem to add new ones to explain functionality. Not the biggest deal, but it is bad for readability in my opinion.
Should be good to merge if no one else finds something wrong.
|
Thank you, Chad @chp2001, for taking the time to test it and for the detailed feedback. I've addressed the readability comment by adding comments back around to make it easier to follow. For the workflow feedback, just to make sure I understand correctly, are you referring to the fact that after trying different models, the UI only shows a generic "completed" message, so it's hard to verify that the selected options (such as the model or forcing dataset) were actually applied? If that's what you mean, I agree that providing more detailed feedback after the workflow completes would improve the user experience, and I'd be happy to work on that as a follow-up improvement. Thanks again for the review. :) |
quinnylee
left a comment
There was a problem hiding this comment.
Really neat work Pratiksha! Thank you! The layout looks great as well. Once the bugs are fixed this should be good to go.
|
Thanks for the review, Quinn @quinnylee . I addressed the requested changes:
I tested these locally with valid basin/gage inputs, an invalid basin/gage ID, and the gage popup link. |
quinnylee
left a comment
There was a problem hiding this comment.
Thanks for the changes! Just one thing, and this is my mistake, the actual default output directory is ~/ngiab_preprocess_output.
Really like the new gage tooltip
|
Sorry, my mistake. I didn't realize the CLI was using the configured output directory and assumed the default was always I've updated it to use the output directory resolved by Also, I've run Ruff formatting locally and pushed the formatting changes. |
quinnylee
left a comment
There was a problem hiding this comment.
Great work @pratikshac15! Ruff formatting is not actually required for merge but still a nice touch. Thanks for all the work!
|
Hey @quinnylee, are we merging this PR? |
@JoshCu your call |
Summary
This PR updates the NGIAB map application workflow (as per Issue #216) to provide a more complete and intuitive interface for running preprocessing and optional NextGen simulations directly from the map.
The workflow has been reorganized to guide users through selecting an input, configuring the simulation, and running the workflow from a single interface, while moving manual steps into a collapsible section below.
Changes
Complete Workflow
Added a unified workflow interface that allows users to:
This update brings key NGIAB workflow options into the map application, enabling configuration and execution of workflows directly through the UI rather than the command line.
Note
This PR focuses on improving the map application workflow and exposing existing CLI functionality through the UI. No changes were made to the underlying preprocessing or model execution logic.