Release v1.0.17: merge dev into main#84
Merged
Merged
Conversation
- Updated the `raw_format` method in the F2 class to return a glob pattern for discovering raw F2 files based on the `proc` argument. - Added support for uncompressed FITS files when `proc` is set to "fits", ".fits", or "uncompressed". - Expanded unit tests to validate the new functionality for the F2 instrument's raw_format method.
- Introduced a new method `discover_raw_files` in the `Instrument` class to handle raw file discovery across specified directories. - Enhanced the `raw_format` method to return appropriate glob patterns based on the `proc` argument, allowing for flexible file matching. - Updated instrument subclasses (F2, GMOS, MOSFIRE, etc.) to utilize the new `_default_raw_format` method for consistency in raw file pattern handling. - Added a human-readable summary method `format_raw_discovery_message` to report search paths and matched files. - Improved error handling in `handle_files` to log discovery messages when no files are found, enhancing user feedback. - Expanded unit tests to validate the new functionality and ensure robust handling of raw file discovery across instruments.
- Introduced a new method `apply_optical_background_subtraction` in the `Instrument` class to handle different background subtraction modes: 'local', 'constant', and 'none'. - Updated the `process_science` method to incorporate the new background subtraction options, replacing the deprecated `skip_skysub` parameter. - Enhanced command-line options in `init_options` to allow users to specify background subtraction mode via `--bkg-sub`. - Modified the `image_proc` function to accept and pass the new `bkg_sub` parameter. - Added unit tests to ensure correct behavior of the new background subtraction features and their integration with existing functionality.
…options - Updated the `process_science` method to fully integrate the new `apply_optical_background_subtraction` functionality, replacing the deprecated `skip_skysub` parameter. - Enhanced command-line options in `init_options` to allow users to specify background subtraction modes via `--bkg-sub`. - Modified the `image_proc` function to accept and pass the new `bkg_sub` parameter for improved flexibility. - Added unit tests to ensure the correct behavior of the updated background subtraction features and their integration with existing functionality.
…ents - Updated `extract_aperture_stats` to include a new parameter `fwhm_measure_radius` for measuring FWHM in a compact aperture, improving accuracy. - Refined the logic for determining the flux aperture radius based on the FWHM measurements. - Introduced a new helper function `_radial_fwhm_from_array` to estimate FWHM from a 2D profile, enhancing the robustness of FWHM extraction. - Modified `extract_fwhm_from_epsf` to fit the Moffat2D model only to the core of the ePSF, preventing overestimation of FWHM from extended wings. - Added unit tests to validate the new FWHM measurement functionality and ensure correct behavior across different scenarios.
…nd-line options - Updated the `process_science` method to fully integrate the `apply_optical_background_subtraction` functionality, replacing the deprecated `skip_skysub` parameter. - Enhanced command-line options in `init_options` to allow users to specify background subtraction modes via `--bkg-sub`. - Modified the `image_proc` function to accept and pass the new `bkg_sub` parameter for improved flexibility. - Added unit tests to ensure the correct behavior of the updated background subtraction features and their integration with existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge
devintomainfor v1.0.17 (~47 commits, 86 files changed). This release hardens the reduction pipeline for production use: photutils 3.x compatibility, robust photometry/zeropoint error handling, configurable per-frame background subtraction, improved WCS/alignment options, and a substantially expanded test suite.Photometry & flux calibration
DAOStarFinder/ApertureStatscolumn names (x_centroidvsxcentroid); guard empty catalogs and missingAPPPHOT.PhotometryError:photloopnow raises on failure instead of silently continuing to zeropoint;absphot.find_zeropointreturnsFalsewith clear logging whenAPPPHOTis missing.tests/test_photometry_regressions.py,tests/test_main_pipeline_photometry.py).Background subtraction
--bkg-subCLI option:local(default 2D mesh),constant(single sigma-clipped median per frame), ornone.--skip-skysubremains as an alias for--bkg-sub none.BKGSUBheader keyword records mode per frame.Instruments & file discovery
instrument_getter: single instrument list in__all__; centralized aliases (BINO→BINOSPEC,MMIR→MMIRS);UnknownInstrumentErrorwith supported-instrument hints.--proc fitsgeneralized across instruments via baseInstrument.raw_format()/discover_raw_files().WCS, alignment & stacking
--skip-external-astrometry: use header WCS only (skip astrometry.net + fine catalog alignment).--fine-align-catalog: Gaia, Pan-STARRS, SDSS, Legacy, 2MASS, SkyMapper.--relative-calibration: SExtractor + RA/Dec cross-match relative flux scaling before stack combine.Calibration & image processing
_read_calibration_ccd); header cleanup to avoid invalid WCS in master bias/flat/dark.Tests, CI & docs
.gitignore:examples/,.coverage.Breaking / behavior changes
KeyErroron missingAPPPHOT).--bkg-sub local); use--bkg-sub constantfor single-level subtraction per frame.potpyri.instruments.resolve_instrument_name().Test plan
pytest tests/— 116 passed locally (1 integration download test may skip/fail on network)pytest -m "not integration"— full non-integration suite passes--bkg-sub constanton extended-source fields (e.g. galaxy targets)Version
Target release: v1.0.17 (
devcurrently at1.0.17.dev27).