Add installation targets#30
Merged
Merged
Conversation
Member
|
You can update the readme with : #include <kkf/extractor.hpp>
#include <kkf/replayer.hpp>Also in the readme, maybe an include example, (I don't know if it's necessary) ? find_package(kkf REQUIRED)
target_link_libraries(my_extractor PRIVATE kkf::kernel_extractor)
target_link_libraries(my_replayer PRIVATE kkf::kernel_replayer) |
daxmawal
reviewed
Jun 19, 2026
Member
|
Thanks @tretre91 |
daxmawal
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces installation targets so that the extract/replay libs and the tool can be installed and consumed by other CMake projects.
I also moved all files in
src/*tosrc/kkf/*so that the headers can be included as#include <kkf/replayer.hpp>The PR also adds CI steps to install the project and use it in a separate CMake project.