Skip to content

handle hdf5 and return status#27

Merged
daxmawal merged 8 commits into
mainfrom
fix/handle_hdf5_errors
Jun 18, 2026
Merged

handle hdf5 and return status#27
daxmawal merged 8 commits into
mainfrom
fix/handle_hdf5_errors

Conversation

@daxmawal

Copy link
Copy Markdown
Member

Fix issue #23

Add a RAII ScopedHandle helper to automatically close HDF5 handles.
Check return statuses from HDF5 calls when writing and reading dump files.

daxmawal added 6 commits June 17, 2026 20:03
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
@daxmawal daxmawal marked this pull request as ready for review June 18, 2026 09:11

@yasahi-hpc yasahi-hpc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C++ 20, may be better to use source_location

Comment thread src/hdf5_utils.hpp Outdated
Comment thread src/hdf5_utils.hpp Outdated
daxmawal and others added 2 commits June 18, 2026 17:33
Co-authored-by: yasahi-hpc <57478230+yasahi-hpc@users.noreply.github.com>
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>

@yasahi-hpc yasahi-hpc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxmawal daxmawal merged commit 8fc6df8 into main Jun 18, 2026
6 checks passed
@daxmawal

Copy link
Copy Markdown
Member Author

Thank you @yasahi-hpc merged.

@daxmawal daxmawal deleted the fix/handle_hdf5_errors branch June 18, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants