Ghidra 12.1 support#108
Merged
Merged
Conversation
Jython is now a separate extension in Ghidra 12.1, so its bundled Guava (org.python.google.common.base.Verify) is no longer on the classpath. Switch three files to use com.google.common.base.Verify instead, which was already the import used by the rest of the codebase.
Ghidra 12.1 introduced GhidraSerialFilterFactory which calls ObjectInputFilter.Config.setSerialFilterFactory() during Application.initializeApplication(). This can only be called once per JVM, so test environments that call initializeApplication() crash with IllegalStateException: Cannot replace filter factory. Set the jdk.serialFilterFactory system property at JVM startup for 12.1+ so Ghidra finds its factory already installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.python.google.common.base.Verify) is no longer on the classpath. Three files using that import were switched tocom.google.common.base.Verify, which the rest of the codebase already used.Test plan
GHIDRA_INSTALL_DIR=~/Ghidra/ghidra_12.1_PUBLIC ./gradlew install)