Skip to content

settings additional hotfix - #60

Open
siddharthakonakanchi wants to merge 1 commit into
masterfrom
settinghotfix
Open

settings additional hotfix#60
siddharthakonakanchi wants to merge 1 commit into
masterfrom
settinghotfix

Conversation

@siddharthakonakanchi

Copy link
Copy Markdown
Collaborator

setting module with less test cases

@kartikk

kartikk commented Nov 16, 2017

Copy link
Copy Markdown
Member

Why do you have two pull requests? #59 & #60

@siddharthakonakanchi

siddharthakonakanchi commented Nov 16, 2017 via email

Copy link
Copy Markdown
Collaborator Author

@kartikk kartikk mentioned this pull request Nov 16, 2017
@kartikk
kartikk self-requested a review November 16, 2017 22:12
@kartikk

kartikk commented Nov 16, 2017

Copy link
Copy Markdown
Member

Pull request rejected.

Reason:

  1. Don't add node_modules folder to the repo
  2. Don't add your debug.log file to the repo
  3. Cleanup unnecessary line breaks and commented code from
    • backend/server/routes/api.js
    • src/app/create-meetup-2/edit/edit.component.ts
    • e2e/app.e2e-spec.ts

@siddharthakonakanchi

Copy link
Copy Markdown
Collaborator Author

accept this so I will clone and again check in by removing folders

@kartikk

kartikk commented Nov 27, 2017

Copy link
Copy Markdown
Member

Does not compile

Can you please resolve the issue in src/app/app.module.ts?

Kindly try to make sure your code works before making a pull request to the master branch in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants