Chore: migrate tests from jmockit to mockito to include test coverage in sonar report by mcook42 · Pull Request #229 · CDOT-CV/jpo-ode

mcook42 · 2026-04-25T17:07:36Z

PR Details

Description

This pull request removes JMockit from the project entirely and migrates every test that used it to Mockito, the mocking framework that ships with Spring Boot Test by default. The JMockit Maven dependency and its -javaagent Surefire argument are deleted, and roughly forty test classes across jpo-ode-svcs, jpo-ode-core, jpo-ode-plugins, and jpo-ode-common have been rewritten to use Mockito idioms (@Mock, @InjectMocks, when(...).thenReturn(...), verify(...), mockStatic, mockConstruction).

A small production change was needed to make one class testable without JMockit's constructor mocking: SnmpSession now receives its Snmp and TransportMapping collaborators through new SnmpSessionFactory and TransportMappingFactory Spring beans rather than constructing them directly. Two pre-existing tests that depended on JMockit's ability to mock unmockable third-party constructs (a logger field and an IOException thrown from a final method) have been removed because they cannot be expressed in Mockito, and the scenarios they covered are not reachable through the public API.

Related Issue

N/A.

Motivation and Context

JMockit has not had a meaningful release in years, and its bytecode-rewriting Java agent is incompatible with the JaCoCo agent that SonarCloud relies on for coverage. As long as JMockit was on the classpath, any test it touched was excluded from our SonarCloud coverage numbers, resulting in an artificially low and misleading coverage signal. Moving these tests to Mockito both removes a dead dependency and makes the affected code visible again in coverage analysis. Mockito is already a transitive dependency of spring-boot-starter-test, so this change reduces our dependency footprint rather than expanding it.

How Has This Been Tested?

The full Maven test suite (mvn clean verify) was run locally and passed. CI runs the same suite on every push to this branch.

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
ODE Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.

…led annotation and associated ticket number

…les for upgrade to Spring

…@KafkaListener

…ountDownLatch for message validation

…m implementation

…ad of EmbeddedKafkaZKBroker for transition to kraft instead of zookeeper

…er, remove EmbeddedKafkaHolder usage

…ner, replace EmbeddedKafkaHolder with CountDownLatch for async validation

…er, replace EmbeddedKafkaHolder with CountDownLatch for async validation

…ner, replace EmbeddedKafkaHolder with CountDownLatch for async validation

…@KafkaListener, replace EmbeddedKafkaHolder with CountDownLatch for async validation

…@KafkaListener, remove EmbeddedKafkaHolder usage

…ner in all tests, refactor tests to use CountDownLatch for async validation

…er, remove EmbeddedKafkaHolder usage

…ing package changes

…ataRouterTest

…CertPresent field

…ntrollerTest and change order of creation of consumers

…rConfigTest and update topic handling logic

…on of isCertPresent field" This reverts commit 65a81c0.

- TimDeleteController: add Javadoc to constructor and deleteTim, break long log line, restore license-header trailing whitespace to match master (drops empty-line JavadocParagraph noise) - TimQueryController: add ending period to bulkQuery Javadoc summary

Copilot

Pull request overview

This PR removes the legacy JMockit-based testing approach (and its Java agent) and migrates affected tests to Mockito so that JaCoCo/Sonar coverage can include the previously excluded test suite. It also introduces a small SNMP construction seam (factory injection) to replace JMockit constructor-mocking needs.

Changes:

Removed the JMockit Maven dependency and Surefire -javaagent configuration.
Migrated a large set of tests from JMockit idioms to Mockito (including static and constructor mocking).
Refactored SNMP session creation to be injectable via new factory interfaces / Spring configuration to support Mockito-based tests.

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pom.xml	Removes JMockit dependency and its Surefire agent configuration.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimQueryControllerTest.java	Migrates TIM query controller tests from JMockit to Mockito; introduces `SnmpSessionFactory` mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimDepositControllerTest.java	Replaces JMockit static/constructor mocking with Mockito static mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimDeleteControllerTest.java	Migrates TIM delete controller tests to Mockito and adapts to `SnmpSessionFactory`.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/stomp/WebSocketConfigTest.java	Converts JMockit verifications to Mockito `verify(...)`.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/stomp/StompControllerTest.java	Migrates controller tests to Mockito + JUnit Jupiter.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/snmp/SnmpSessionTest.java	Updates SNMP session tests to Mockito; adds coverage for transport-construction failure via factory.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/rsuHealth/RsuSnmpTest.java	Migrates RSU SNMP tests to Mockito and adds interaction verification.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/rsuHealth/RsuHealthControllerTest.java	Replaces JMockit constructor/static mocking with Mockito `mockConstruction`/`mockStatic`.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/PdmUtilTest.java	Converts PDM util test to Mockito.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/PdmControllerTest.java	Migrates controller tests to Mockito static/constructor mocking for `JsonUtils` and `SnmpSession`.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/J2735PdmRequestTest.java	Removes JMockit usage; uses direct instantiation under JUnit Jupiter.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/SystemConfigTest.java	Updates assertions to JUnit Jupiter.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/OdePropertiesControllerTest.java	Migrates to Mockito + JUnit Jupiter and removes JMockit expectations.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/traveler/TimQueryController.java	Injects `SnmpSessionFactory` instead of direct `new SnmpSession(...)`.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/traveler/TimDeleteController.java	Injects `SnmpSessionFactory` instead of direct `new SnmpSession(...)`.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/TransportMappingFactory.java	New functional interface to abstract `TransportMapping` creation for testability.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSessionFactory.java	New functional interface to abstract `SnmpSession` creation for controller testability.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java	Adds a transport-factory constructor to avoid constructor mocking.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpConfig.java	Registers a Spring bean providing the default `SnmpSessionFactory`.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/WeatherProbeBuilderTest.java	Migrates static builder stubbing to Mockito static mocking.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/VehicleSafetyExtensionsBuilderTest.java	Migrates builder static mocking to Mockito.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/TravelerMessageFromHumanToAsnConverterTest.java	Removes JMockit logger mocking setup.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/TimeStampConverterTest.java	Removes JMockit logger mocking setup; updates to JUnit Jupiter assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/SupplementalVehicleExtensionsBuilderTest.java	Migrates multiple static builder stubs to Mockito static mocking.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/Position3DBuilderTest.java	Migrates static helper stubs to Mockito static mocking.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/EventDescriptionBuilderTest.java	Migrates static helper stubs to Mockito static mocking.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/BsmPart2ContentBuilderTest.java	Replaces JMockit capturing with managed Mockito static mocks and verification.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/BsmCoreDataBuilderTest.java	Replaces JMockit capturing with managed Mockito static mocks.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735VehicleStatusRequestTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TransmissionAndSpeedTest.java	Removes JMockit; updates to JUnit Jupiter assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TrailerUnitDescriptionTest.java	Removes JMockit; updates to JUnit Jupiter assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TrailerDataTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SupplementalVehicleExtensionsTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SpeedProfileTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SpecialVehicleExtensionTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735RTCMPackageTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735ProbeDataManagmentTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735PathHistoryPointTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735PathHistoryPointListTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735FullPositionVectorTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735EventDescriptionTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735EmergencyDetailsTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735ChoiceTest.java	Removes a JMockit-only exception test and updates to JUnit Jupiter assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735BsmTest.java	Removes JMockit; uses direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/DdsAdvisoryDetailsTest.java	Removes JMockit instantiation; uses direct instantiation (still has some legacy imports).
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/generic/SituationDataWarehouseTest.java	Migrates to JUnit Jupiter assertions; removes JMockit.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/generic/RoadSideUnitTest.java	Migrates to JUnit Jupiter assertions; removes JMockit.
jpo-ode-core/src/test/java/us/dot/its/jpo/ode/snmp/SNMPTest.java	Migrates to JUnit Jupiter assertions; removes JMockit/JUnit4 patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…rces Replaced manual `snmp.close()` calls with try-with-resources in `RsuHealthController` and adjusted relevant tests. Removed redundant `close()` verifications in `RsuSnmpTest` as the new approach guarantees resource cleanup.

Fixes checkstyle IndentationCheck violations flagged by reviewdog on PR #229. The try-with-resources refactor introduced 4-space indentation for the try body; Google style (basicOffset=2) requires 2 spaces per level. Reformatted the entire class for consistency and split the overlong method signature onto separate lines.

…at method Fixes missing-Javadoc and empty-line-before-tag checkstyle violations reported by the reviewdog bot on PR #229.

mcook42 · 2026-04-29T19:32:40Z

-        Snmp snmp = new Snmp(transport);
-        USM usm = new USM(SecurityProtocols.getInstance(), new OctetString(MPv3.createLocalEngineID()), 0);
+    TransportMapping transport = new DefaultUdpTransportMapping();
+    try (Snmp snmp = new Snmp(transport)) {


Note: I added this try-with-resources block to resolve a resource leak issue found during the test framework migration. It isn't necessary for the jmockit removal, but it is necessary to prevent resource leaks in the running application when an exception is thrown during SNMP command execution in RsuSnmp.sendSnmpV3Request

Copilot

Pull request overview

This PR removes JMockit usage across the codebase by migrating affected unit tests to Mockito (including static/construction mocking) so JaCoCo/Sonar can report coverage, and introduces a small SNMP session-construction seam to keep SNMP-related controllers testable without constructor mocking.

Changes:

Removed the JMockit dependency and Surefire -javaagent configuration from the root pom.xml.
Rewrote a large set of tests from JMockit idioms to Mockito/JUnit 5 idioms.
Updated SNMP-related production code to inject SnmpSession creation via a SnmpSessionFactory, and added supporting factory/config types.

Reviewed changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pom.xml	Removes JMockit dependency and Surefire javaagent configuration.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimQueryControllerTest.java	Migrates TIM query controller tests from JMockit to Mockito.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimDepositControllerTest.java	Migrates TIM deposit controller tests to Mockito static mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimDeleteControllerTest.java	Migrates TIM delete controller tests to Mockito with injected factory.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/stomp/WebSocketConfigTest.java	Replaces JMockit verifications with Mockito verify calls.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/stomp/StompControllerTest.java	Migrates to Mockito extension + JUnit 5 assertions.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/snmp/SnmpSessionTest.java	Updates SNMP session tests to use a transport factory seam instead of constructor mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/rsuHealth/RsuSnmpTest.java	Migrates RSU SNMP unit tests from JMockit to Mockito.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/rsuHealth/RsuHealthControllerTest.java	Migrates heartbeat tests using Mockito static/construction mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/PdmUtilTest.java	Migrates PDM util tests to Mockito.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/PdmControllerTest.java	Migrates PDM controller tests using Mockito static/construction mocking.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/pdm/J2735PdmRequestTest.java	Removes JMockit `@Tested` usage; uses direct construction.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/SystemConfigTest.java	Converts assertions to JUnit 5 style.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/OdePropertiesControllerTest.java	Migrates to Mockito extension + stubbing for properties.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/traveler/TimQueryController.java	Injects `SnmpSessionFactory` and uses it for session creation.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/traveler/TimDeleteController.java	Injects `SnmpSessionFactory` and uses it for session creation.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/TransportMappingFactory.java	Adds a transport factory interface to enable constructor-failure testing.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSessionFactory.java	Adds a session factory interface for injection/testing.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java	Adds constructor overload using `TransportMappingFactory`.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpConfig.java	Provides a Spring bean for `SnmpSessionFactory`.
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/heartbeat/RsuSnmp.java	Stops closing `Snmp` inside helper (caller now owns lifecycle).
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/heartbeat/RsuHealthController.java	Uses try-with-resources to manage `Snmp` lifecycle and adds docs.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/WeatherProbeBuilderTest.java	Migrates static builder mocking to Mockito `mockStatic`.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/VehicleSafetyExtensionsBuilderTest.java	Migrates static builder mocking and updates assertion style.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/TravelerMessageFromHumanToAsnConverterTest.java	Removes logger mocking previously done with JMockit.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/TimeStampConverterTest.java	Removes JMockit logger mocking and updates assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/SupplementalVehicleExtensionsBuilderTest.java	Migrates multiple static builder mocks to Mockito.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/Position3DBuilderTest.java	Migrates static builder mocking to Mockito and updates assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/EventDescriptionBuilderTest.java	Migrates static CodecUtils mocking and updates assertion ordering.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/BsmPart2ContentBuilderTest.java	Reworks capturing/verifications into Mockito static mocks + verify.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/builders/BsmCoreDataBuilderTest.java	Adds lifecycle-managed Mockito static mocks for collaborating builders.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735VehicleStatusRequestTest.java	Replaces JMockit `@Tested` with direct instantiation and JUnit 5 assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TransmissionAndSpeedTest.java	Normalizes header formatting and uses JUnit 5 assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TrailerUnitDescriptionTest.java	Replaces JMockit `@Tested` with direct instantiation and JUnit 5 assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735TrailerDataTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SupplementalVehicleExtensionsTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SpeedProfileTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735SpecialVehicleExtensionTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735RTCMPackageTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735ProbeDataManagmentTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735PathHistoryPointTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735PathHistoryPointListTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735FullPositionVectorTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735EventDescriptionTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735EmergencyDetailsTest.java	Replaces JMockit `@Tested` with direct instantiation.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735ChoiceTest.java	Removes a JMockit-based exception test that depended on mocking logging internals.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/J2735BsmTest.java	Replaces JMockit mocking with direct instantiation + JUnit 5 assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/j2735/DdsAdvisoryDetailsTest.java	Removes JMockit `@Tested` usage while keeping test behavior.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/generic/SituationDataWarehouseTest.java	Replaces JMockit `@Tested` with direct instantiation and JUnit 5 assertions.
jpo-ode-plugins/src/test/java/us/dot/its/jpo/ode/plugin/generic/RoadSideUnitTest.java	Migrates to JUnit 5 assertions and removes JMockit `@Tested`.
jpo-ode-core/src/test/java/us/dot/its/jpo/ode/snmp/SNMPTest.java	Updates to JUnit 5 assertions and removes unused JMockit/JUnit4 annotations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mcook42 · 2026-04-29T19:33:41Z

        ResponseEvent responseEvent;
        try {
            responseEvent = snmp.send(pdu, target);
-            snmp.close();


note: this was removed as the try-with-resources block we added in RsuHealthController now manages the lifecycle of the SNMP resource in both success and error conditions

…ove-jmockit

…ests

Copilot

Pull request overview

Copilot reviewed 52 out of 52 changed files in this pull request and generated 5 comments.

pmonington

Looks good to me!

Russ-Garrett-Trihydro

Looks good. I found an issue with testing Kafka Streams in jpo-ode-svcs, but it isn't related to the changes in this PR.

pmonington added 30 commits April 14, 2026 13:16

test: disable broken test Asn1DecodedDataRouterTIMDataFlow with Disab…

fe59c5a

…led annotation and associated ticket number

tool: use rewrite recipe to update dependencies and plugins in pom fi…

c3ec53d

…les for upgrade to Spring

test: refactor RawEncodedTIMJsonRouterTest to use @embeddedkafka and …

d53aeda

…@KafkaListener

test: refactor RawEncodedSSMJsonRouterTest to use @embeddedkafka and …

2b2316a

…@KafkaListener

test: refactor RawEncodedSRMJsonRouterTest to use EmbeddedKafka and C…

cfed20b

…ountDownLatch for message validation

test: refactor MapReceiverTest to use @embeddedkafka and @KafkaListener

2bd4a54

refactor: update related imports for Spring updates

4ce1ee7

refactor: replace io.netty UnsupportedMessageTypeException with custo…

5086432

…m implementation

fix: update EmbeddedKafkaHolder to use EmbeddedKafkaKraftBroker inste…

ae07690

…ad of EmbeddedKafkaZKBroker for transition to kraft instead of zookeeper

test: refactor SrmReceiverTest to use @embeddedkafka and @KafkaListen…

32348bc

…er, remove EmbeddedKafkaHolder usage

test: refactor SsmReceiverTest to use @embeddedkafka and @KafkaListen…

f5f2d02

…er, remove EmbeddedKafkaHolder usage

test: refactor RtcmReceiverTest to use @embeddedkafka and @KafkaListe…

1d0831c

…ner, replace EmbeddedKafkaHolder with CountDownLatch for async validation

test: refactor SdsmReceiverTest to use @embeddedkafka and @KafkaListe…

71c481d

…ner, replace EmbeddedKafkaHolder with CountDownLatch for async validation

test: refactor PsmReceiverTest to use @embeddedkafka and @KafkaListen…

71559e4

…er, replace EmbeddedKafkaHolder with CountDownLatch for async validation

test: refactor SpatReceiverTest to use @embeddedkafka and @KafkaListe…

bcd51cc

…ner, replace EmbeddedKafkaHolder with CountDownLatch for async validation

test: remove EmbeddedKafkaHolder usage in SpatReceiverTest

5eb8e03

test: refactor RawEncodedSRMJsonRouterTest to use @embeddedkafka and …

43ff246

…@KafkaListener, replace EmbeddedKafkaHolder with CountDownLatch for async validation

test: remove unused imports in RawEncodedSRMJsonRouterTest

3fc9477

test: refactor RawEncodedBSMJsonRouterTest to use @embeddedkafka and …

352f139

…@KafkaListener, remove EmbeddedKafkaHolder usage

chore: remove obsolete kafka_2.11 dependency from pom.xml

bf831a0

test: replace EmbeddedKafkaHolder with @embeddedkafka and @KafkaListe…

43583a9

…ner in all tests, refactor tests to use CountDownLatch for async validation

test: refactor RsmReceiverTest to use @embeddedkafka and @KafkaListen…

cacd39d

…er, remove EmbeddedKafkaHolder usage

refactor(test): update KafkaProperties import paths to align with Spr…

8f73dfa

…ing package changes

test: replace EmbeddedKafkaHolder with @embeddedkafka in Asn1EncodedD…

1bd9860

…ataRouterTest

test: replace EmbeddedKafkaHolder with @embeddedkafka in Asn1DecodedD…

69c7179

…ataRouterTest

refactor: add @Getter annotation to ensure proper serialization of is…

65a81c0

…CertPresent field

test: replace EmbeddedKafkaHolder with @embeddedkafka in TimDepositCo…

8d2fcfd

…ntrollerTest and change order of creation of consumers

test: replace EmbeddedKafkaHolder with @embeddedkafka in KafkaProduce…

ea39409

…rConfigTest and update topic handling logic

tool: add lombok configuration to copy Jackson annotations to accessors

f4ada6d

Revert "refactor: add @Getter annotation to ensure proper serializati…

ea24e34

…on of isCertPresent field" This reverts commit 65a81c0.

mcook42 marked this pull request as ready for review April 27, 2026 21:39

mcook42 requested review from Copilot, iyourshaw and pmonington April 27, 2026 21:39

Copilot AI reviewed Apr 27, 2026

View reviewed changes

github-actions Bot reviewed Apr 29, 2026

View reviewed changes

mcook42 marked this pull request as draft April 29, 2026 18:58

github-actions Bot reviewed Apr 29, 2026

View reviewed changes

docs(heartbeat): add Javadoc to RsuHealthController class and heartBe…

ebb3d65

…at method Fixes missing-Javadoc and empty-line-before-tag checkstyle violations reported by the reviewdog bot on PR #229.

mcook42 requested a review from Copilot April 29, 2026 19:28

Copilot started reviewing on behalf of mcook42 April 29, 2026 19:29 View session

mcook42 commented Apr 29, 2026

View reviewed changes

Copilot AI reviewed Apr 29, 2026

View reviewed changes

mcook42 commented Apr 29, 2026

View reviewed changes

mcook42 marked this pull request as ready for review April 29, 2026 19:36

test(rsu): replace assert with assertNull in deserialization test

bb3e81a

Base automatically changed from pmonington/upgrade-spring to develop June 5, 2026 20:47

mcook42 added 2 commits June 8, 2026 09:20

Merge branch 'develop' of github.com:CDOT-CV/jpo-ode into mcook42/rem…

9339275

…ove-jmockit

test(kafka): clean up redundant annotations in RawEncodedJsonRouter t…

500ac0e

…ests

mcook42 requested a review from Copilot June 8, 2026 16:10

Copilot started reviewing on behalf of mcook42 June 8, 2026 16:11 View session

mcook42 requested a review from Russ-Garrett-Trihydro June 8, 2026 16:14

Copilot AI reviewed Jun 8, 2026

View reviewed changes

pmonington approved these changes Jun 8, 2026

View reviewed changes

Russ-Garrett-Trihydro approved these changes Jun 10, 2026

View reviewed changes

mcook42 merged commit f404dd3 into develop Jun 10, 2026
7 checks passed

mcook42 deleted the mcook42/remove-jmockit branch June 10, 2026 18:11

Uh oh!

Conversation

mcook42 commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcook42 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcook42 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmonington left a comment

Choose a reason for hiding this comment

Uh oh!

Russ-Garrett-Trihydro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mcook42 commented Apr 25, 2026 •

edited

Loading