Intersection Map Bugfixes

[jacob6838]

PR Details

Description

Fixing bugs in Intersection Map

• unnecessarily requries ingressApproach values
• poor error handling for empty data in ZIP uploads
• Exported ZIP missing MAP and SPaT data
• Intersection map/dashboard intersections were not filtered by the selected Organization

How Has This Been Tested?

The following tests were all completed on the local system running in docker:

• MAP/SPaT visualizer tested with MAP lanes missing ingressApproach, and spat signal states were rendered correctly
• ZIP file with empty BSM document was uploaded and successfully processed/rendered MAP and SPaT data
• Successfully exported MAP, SPaT, and BSM data

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• My changes require new environment variables:
  • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
• My changes require updates to the documentation:
  • I have updated the documentation accordingly.
• My changes require updates and/or additions to the unit tests:
  • I have modified/added tests to cover my changes.
• All existing tests pass.

[Copilot]

Pull request overview

This PR targets defect fixes in the Intersection Map feature by loosening map parsing requirements (so missing ingressApproach data doesn’t block processing) and improving robustness when importing message data from ZIP uploads.

Changes:

• Updated MAP signal group parsing to only require signalGroup (no longer requires ingressApproach) and added a warning when it’s missing.
• Added guarded JSON parsing for BSM ZIP entries and a user-facing error toast when imported ZIP contents appear empty/invalid.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
webapp/src/features/intersections/map/utilities/message-utils.ts	Relaxes signal-state feature creation requirements and adds logging when signalGroup is missing.
webapp/src/features/intersections/map/control-panel.tsx	Adds additional ZIP import error handling for BSM parsing and “empty upload” feedback.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[drewjj]

These fixes look reasonable to me!

[payneBrandon]

Do we have tests for any of these updates? If not can we add them in?

[jacob6838]

@payneBrandon I just added unit tests for message-utils and mm-api