chore: Factored out impl_property_eq_hash! as user-facing macro#927
Open
RobertJacobsonCDC wants to merge 1 commit into
Open
chore: Factored out impl_property_eq_hash! as user-facing macro#927RobertJacobsonCDC wants to merge 1 commit into
impl_property_eq_hash! as user-facing macro#927RobertJacobsonCDC wants to merge 1 commit into
Conversation
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new user-facing macros:
impl_property_eq!PartialEqandEqimpl_property_hash!Hashimpl_property_eq_hash!I also added language to the Properties chapter of the Ixa Book explaining when to use them.
The point of these is, client code can now use them to generate implementations for these traits when they cannot be derived in the case they define the property type themselves instead of using
define_*_property!macros.These macros previously existed as "internal subcommands" of the
define_property!macro, so from that point of view this isn't exactly new functionality. It's just that it's now intended to be exposed to the end user.