feat: Add Modal History Navigation and Local Development Setup#290
Open
davidjeonai-web wants to merge 3 commits into
Open
feat: Add Modal History Navigation and Local Development Setup#290davidjeonai-web wants to merge 3 commits into
davidjeonai-web wants to merge 3 commits into
Conversation
…n't be missed and added local environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Overview
This PR introduces a modal history navigation (back button functionality) for multi-popup scenarios and significantly improves the local development workflow by adding a dedicated static build setup. These enhancements are strictly additive and introduce no breaking changes to existing functionality.
🛠️ Changes Made
1. Modal History & Back Functionality
modal.js:modalHistorystack to track content states.historyLengthgetter and agoBack()method to navigate through previous states.modal.stache:modalHistory.length > 1).goBack().modal.less:.backbutton, including focus/hover states.2. Local Development Setup
package.json: Added a newdevscript to streamline local builds and serve files locally (node scripts/build.local.js && npx http-server dist_local).build.viewer.html.js:isLocalparameter.templatePathvariable.index.htmllocally rather than thedemofolder.README.md: Added a comprehensive "Local Development & Testing" section detailing how to place guide files, use thenpm run devcommand, and understand current HMR limitations..gitignore: Addeddist_local,index.html, anddefaultto prevent accidental commits of local build artifacts and sample guide files.scripts/Directory: Added a new directory to house local build utilities and scripts.🧪 Impact