Add Heuristic Backbone#24
Open
robertjosephpalermo wants to merge 15 commits into
Open
Conversation
fxcosta-phd
requested changes
Jun 17, 2026
fxcosta-phd
left a comment
Collaborator
There was a problem hiding this comment.
@robertjosephpalermo It would be best to clean up the code prior to merging. Here is my brief revision:
- It seems that most of the changes was separating the function arguments to multiple lines instead of a single line. Please keep them all in a single line.
- Why line 155 has disjuntion=drastic_disjunction?
- The code now seems to import Callable, why?
- There was a test_heuristic_backbone function in here which should still exist, but in a different file, namely in the test folder.
Author
|
Refactor distance closure functions to use 'kind' parameter for disjunction type. Update function signatures and documentation accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fxcosta-phd