Skip to content

Add Heuristic Backbone#24

Open
robertjosephpalermo wants to merge 15 commits into
CASCI-lab:heuristic_backbonefrom
robertjosephpalermo:heuristic_backbone
Open

Add Heuristic Backbone#24
robertjosephpalermo wants to merge 15 commits into
CASCI-lab:heuristic_backbonefrom
robertjosephpalermo:heuristic_backbone

Conversation

@robertjosephpalermo

@robertjosephpalermo robertjosephpalermo commented Jun 15, 2026

Copy link
Copy Markdown

@fxcosta-phd

  • Adds the heuristic backbone function
  • Cleans up the code that was already there

@fxcosta-phd fxcosta-phd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertjosephpalermo It would be best to clean up the code prior to merging. Here is my brief revision:

  • It seems that most of the changes was separating the function arguments to multiple lines instead of a single line. Please keep them all in a single line.
  • Why line 155 has disjuntion=drastic_disjunction?
  • The code now seems to import Callable, why?
  • There was a test_heuristic_backbone function in here which should still exist, but in a different file, namely in the test folder.

@robertjosephpalermo

robertjosephpalermo commented Jun 17, 2026

Copy link
Copy Markdown
Author

@robertjosephpalermo It would be best to clean up the code prior to merging. Here is my brief revision:

  • It seems that most of the changes was separating the function arguments to multiple lines instead of a single line. Please keep them all in a single line.
  • Why line 155 has disjuntion=drastic_disjunction?
  • The code now seems to import Callable, why?
  • There was a test_heuristic_backbone function in here which should still exist, but in a different file, namely in the test folder.
  1. Yes many of the changes were reformatting the long function lines with the intention of increasing readability. I will change it back.
  2. I will fix that, it should be just "disjunction".
  3. "Callable" is used as a type hint for the disjunctions, for example in the "_local_semi_triangles" function.
  4. I will add back the test file.

robertjosephpalermo and others added 3 commits June 17, 2026 18:49
Refactor distance closure functions to use 'kind' parameter for disjunction type. Update function signatures and documentation accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants