fix(package): added tzdata to uv so windows systems can run the bot - #51
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds the tzdata package as a runtime dependency so the bot can correctly handle timezones on Windows systems, and updates the lockfile accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since tzdata is only needed on Windows, consider adding it with an environment marker (e.g.,
tzdata>=2025.3; sys_platform == 'win32') so non-Windows environments don't install an unnecessary dependency. - Review whether
tzdata>=2025.3is intentionally targeting a future/very specific version; if not, you may want a looser lower bound (or no explicit lower bound) to avoid unnecessary version constraints.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since tzdata is only needed on Windows, consider adding it with an environment marker (e.g., `tzdata>=2025.3; sys_platform == 'win32'`) so non-Windows environments don't install an unnecessary dependency.
- Review whether `tzdata>=2025.3` is intentionally targeting a future/very specific version; if not, you may want a looser lower bound (or no explicit lower bound) to avoid unnecessary version constraints.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR adds the tzdata package as a dependency to enable Windows systems to run the bot. The tzdata package provides IANA timezone database data, which is required by Python's zoneinfo module but is not available by default on Windows systems.
Changes:
- Added
tzdata>=2025.3to project dependencies inpyproject.toml - Updated dependency lock file
uv.lockwithtzdatapackage metadata, hashes, and download URLs
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added tzdata>=2025.3 to dependencies array (reformatted to multi-line for readability) |
| uv.lock | Added complete package metadata for tzdata 2025.3 including source registry, download URLs, and SHA256 hashes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by Sourcery
Bug Fixes: