Skip to content

fix(package): added tzdata to uv so windows systems can run the bot - #51

Merged
shamikkarkhanis merged 2 commits into
mainfrom
feature/cap-258-tzdata
Jan 31, 2026
Merged

fix(package): added tzdata to uv so windows systems can run the bot#51
shamikkarkhanis merged 2 commits into
mainfrom
feature/cap-258-tzdata

Conversation

@simtiaz5

@simtiaz5 simtiaz5 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Bug Fixes:

  • Ensure the bot can access time zone data on platforms that do not provide it by default, such as Windows, by depending on tzdata.

@simtiaz5 simtiaz5 self-assigned this Jan 31, 2026
Copilot AI review requested due to automatic review settings January 31, 2026 00:14
@sourcery-ai

sourcery-ai Bot commented Jan 31, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the tzdata package as a runtime dependency so the bot can correctly handle timezones on Windows systems, and updates the lockfile accordingly.

File-Level Changes

Change Details Files
Add tzdata as an application dependency to ensure timezone data is available at runtime, particularly on Windows.
  • Extend the dependencies list in pyproject.toml to include tzdata with a minimum version constraint.
  • Regenerate or update uv.lock to capture the resolved tzdata package and any related dependency graph changes.
pyproject.toml
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since tzdata is only needed on Windows, consider adding it with an environment marker (e.g., tzdata>=2025.3; sys_platform == 'win32') so non-Windows environments don't install an unnecessary dependency.
  • Review whether tzdata>=2025.3 is intentionally targeting a future/very specific version; if not, you may want a looser lower bound (or no explicit lower bound) to avoid unnecessary version constraints.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since tzdata is only needed on Windows, consider adding it with an environment marker (e.g., `tzdata>=2025.3; sys_platform == 'win32'`) so non-Windows environments don't install an unnecessary dependency.
- Review whether `tzdata>=2025.3` is intentionally targeting a future/very specific version; if not, you may want a looser lower bound (or no explicit lower bound) to avoid unnecessary version constraints.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the tzdata package as a dependency to enable Windows systems to run the bot. The tzdata package provides IANA timezone database data, which is required by Python's zoneinfo module but is not available by default on Windows systems.

Changes:

  • Added tzdata>=2025.3 to project dependencies in pyproject.toml
  • Updated dependency lock file uv.lock with tzdata package metadata, hashes, and download URLs

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Added tzdata>=2025.3 to dependencies array (reformatted to multi-line for readability)
uv.lock Added complete package metadata for tzdata 2025.3 including source registry, download URLs, and SHA256 hashes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shamikkarkhanis shamikkarkhanis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shamikkarkhanis
shamikkarkhanis merged commit 98fb4fd into main Jan 31, 2026
10 checks passed
@shamikkarkhanis
shamikkarkhanis deleted the feature/cap-258-tzdata branch January 31, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants