Skip to content

Add nonzero tolerance for THETA_REF_ME with dace_gpu#1352

Open
msimberg wants to merge 1 commit into
C2SM:mainfrom
msimberg:theta-ref-dace-gpu
Open

Add nonzero tolerance for THETA_REF_ME with dace_gpu#1352
msimberg wants to merge 1 commit into
C2SM:mainfrom
msimberg:theta-ref-dace-gpu

Conversation

@msimberg

Copy link
Copy Markdown
Contributor

Like in #1343, add nonzero tolerance for THETA_REF_ME. However, this seems to be indeterministic dace behaviour. The test sometimes passes with zero tolerance and sometimes doesn't. It has failed for example on https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504678/-/jobs/15058348456#L1862.

@github-actions

Copy link
Copy Markdown

Mandatory Tests

Before merging, run the merge pipeline with cscs-ci run merge. Merging is blocked unless this pipeline passes.

When developing, you can test your changes on CSCS CI before merge with the default pipeline: cscs-ci run default. This will run a default subset of tests.

You can pass options to override pipeline variables, for example:

  • cscs-ci run default;BACKENDS=gtfn_cpu;LEVELS=unit
  • cscs-ci run default;MODEL_SUBPACKAGES=common:driver;SESSIONS=model
    Avoid running the pipeline for all tests when you are developing.

Available options are:

  • SESSIONS: model, model_mpi, or tools (correspond to nox sessions)
  • MODEL_SUBSETS: datatest, basic, or stencils (correspond to nox session selections)
  • MODEL_SUBPACKAGES: subpackages for non-MPI tests (last component, e.g. diffusion, standalone_driver)
  • MODEL_MPI_SUBPACKAGES: subpackages for MPI tests (as above)
  • BACKENDS: backends
  • GRIDS: grids for stencil tests (simple, icon_regional, or icon_global)
  • LEVELS: testing level for non-stencil tests (any, unit, or integration)

See scripts/python/generate_ci_pipeline.py and noxfile.py for available values for each option.

The all pipeline can be run with cscs-ci run all. This will run all icon4py tests in CSCS CI which can be expensive. This pipeline runs on a schedule on main, and can be run when extensive validation is needed (e.g. before releases).

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

For more detailed information please look at CI in the EXCLAIM universe.

@msimberg msimberg changed the title Add nonzero tolerance for THETA_REF_ME with dace_gpu Add nonzero tolerance for THETA_REF_ME with dace_gpu Jun 26, 2026
@msimberg msimberg requested a review from jcanton June 26, 2026 19:17

@jcanton jcanton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for friday night work

@msimberg

Copy link
Copy Markdown
Contributor Author

cscs-ci run merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants