This repository was archived by the owner on Dec 22, 2023. It is now read-only.
New plugin rofl#158
Open
jurkov wants to merge 3 commits into
Open
Conversation
Member
|
Those are quite a few lines that spits out. That could be problematic when it's used two or three times in a row and the bot either rate-limits itself or gets kicked for flooding.. :/ |
Contributor
Author
|
I think this is something really important for every plugin. Can we out source something like that to the bytebot irc engine? |
Member
|
IIRC irc3 already does rate-limit the privmsg to prevent flood-kicks, but with that many lines, it's probable that people will write inbetween the lines of the copter... |
Contributor
|
Plugin is now about an year old... IMHO breaking the output by users is not an problem as the output is just for fun. @mkzero: Seems to be OK, we should merge (and have some fun). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just created the roflcopter command requested (#129) on the hacktoberfest event.