Clarify worker function load failures#195
Open
JacobZuliani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a worker failed while deserializing
function_pkl, node assignment raised a node-service 500. The client then reported onlyFailed to assign <node>: 500, hiding the real cause, such asmpq.__new__() missing 1 required positional argument: 'p'duringcloudpickle.loads().Solution
load_function()errors during node assignment.422 function_load_failedresponse containing the original traceback.FunctionLoadErrorinstead of a generic assignment failure.How This Fixes It
The failure is now treated as a user-function load/deserialization problem before any inputs run, not as node infrastructure failure. Users get the actionable traceback from the worker, and the node is left ready for later jobs instead of rebooting from middleware 500 handling.
Test plan
uv run --project client pytest client/tests/test_rpm_exceptions.py -m unituv run --project node_service python -m py_compile node_service/src/node_service/job_endpoints.py