PR9: Bullnym protocol foundation#39
Open
BullishNode wants to merge 9 commits into
Open
Conversation
BullishNode
force-pushed
the
pr08-nostr-core
branch
from
fd06c96 to
a0edd7a
Compare
BullishNode
force-pushed
the
pr09-bullnym-protocol-foundation
branch
from
42a1b82 to
70d0464
Compare
BullishNode
force-pushed
the
pr08-nostr-core
branch
from
a0edd7a to
82a8f56
Compare
BullishNode
force-pushed
the
pr09-bullnym-protocol-foundation
branch
from
70d0464 to
bbd17ac
Compare
BullishNode
force-pushed
the
pr08-nostr-core
branch
from
82a8f56 to
cd20c3a
Compare
BullishNode
force-pushed
the
pr09-bullnym-protocol-foundation
branch
from
bbd17ac to
6ef2ddb
Compare
Repeated Error-vs-Exception rename churn across the stack's new features stems from the doc only naming `<Feature>Error`. Record that `<Feature>Exception` is the same conformant surface (one sealed family per feature, every variant with toTranslated, foreign errors mapped at the boundary) - the suffix is a naming choice, not a design difference, and neither warrants a rename. The thing to fold in is a standalone one-off exception outside its family (R2-AD9c).
bullnym_error.dart routed all eight error kinds through borrowed mempoolError* keys (the third recurrence of cross-feature l10n key reuse). Add dedicated bullnym* keys to the en template with bullnym-correct copy and repoint toTranslated at them, so bullnym error text no longer inherits mempool semantics and its localization can evolve independently. Other locales fall back to en until translated upstream (R2-AD9a).
The `models` vocabulary is reserved for data-layer wire types; these are domain result types (BullnymRegisterResult, BullnymLookupResult). Rename the file to a domain-appropriate name and update its importers. No behavior change (R2-AD9b).
BullishNode
force-pushed
the
pr09-bullnym-protocol-foundation
branch
from
6ef2ddb to
92399aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical numbered stack rebuild.\n\nBase: pr08-nostr-core\nHead: pr09-bullnym-protocol-foundation\n\nThis replaces the earlier mixed-head review PRs, which used unnumbered head branches against numbered base branches. The branch chain is now canonical and numbered end to end.